[llvm-dev] RFC: changing variable naming rules in LLVM codebase

Chris Lattner via llvm-dev llvm-dev at lists.llvm.org
Fri May 24 23:00:16 PDT 2019

Hi Michael,

I’m still very interested in seeing a change here.  If someone is interested in seeing a codebase using the proposed camelBack convention for variables names, the MLIR codebase is public <https://github.com/tensorflow/mlir> and uses it.

If you’re curious to see what this looks like in practice, there are lots of examples in the codebase, here is an example .cpp file <https://github.com/tensorflow/mlir/blob/master/lib/Transforms/LoopUnrollAndJam.cpp>, here is another <https://github.com/tensorflow/mlir/blob/master/lib/Parser/Parser.cpp>, here is an example header <https://github.com/tensorflow/mlir/blob/master/include/mlir/IR/Location.h>.

We are still working our way through open sourcing logistics (not all the code is out yet), but we would still like to contribute at least parts of this to LLVM if the project is interested.  [[This is just an FYI, not itself a proposal yet - one will be coming when we’re ready.]]


> On May 21, 2019, at 3:01 AM, Michael Platings via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> Hi folks,
> Git is on its way to learning how to ignore commits, allowing us to do variable renaming and other small refactorings without breaking git blame.
> It's like git-hyper-blame [1] but significantly more powerful as it uses fuzzy matching to match lines, including lines that may have been split or joined.
> A preview release of Git with this new feature is at: https://github.com/mplatings/git/releases/tag/ignore-rev
> Some of you have told me that you already have to spend time running git blame multiple times to look past uninteresting commits so I'd love for you to give this feature a try and see if it helps you. Your feedback will be very valuable.
> Thanks,
> -Michael
> [1] https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190524/cd034c29/attachment.html>

More information about the llvm-dev mailing list