[llvm-dev] DWARF debug info unit tests: Tests for wrong triple?

Hubert Tong via llvm-dev llvm-dev at lists.llvm.org
Thu Mar 21 09:16:46 PDT 2019


On Thu, Mar 21, 2019 at 7:55 AM <paul.robinson at sony.com> wrote:

> +1.  We run a cross-compile environment but as it's the same target
> architecture as our hosts, we don't run into quite the same issue; but I
> would like to see the unittests pay attention to the default target triple.
>
> Note there are some builds that do not *have* a default target triple, so
> you'll want to do something sensible there.
>
Thanks for the tip. I'll keep that in mind.

-- HT


> --paulr
>
>
>
> *From:* llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] *On Behalf Of *Hubert
> Tong via llvm-dev
> *Sent:* Thursday, March 21, 2019 12:05 AM
> *To:* Eric Christopher
> *Cc:* llvm-dev
> *Subject:* Re: [llvm-dev] DWARF debug info unit tests: Tests for wrong
> triple?
>
>
>
> On Wed, Mar 20, 2019 at 7:29 PM Eric Christopher <echristo at gmail.com>
> wrote:
>
> Adding in aprantl here to make sure he's aware.
>
> Making sure I understand - you're building a compiler on machine a
> that llvm doesn't support code generation to and running the llvm
> tests on that platform?
>
> Yes, or rather the support is in-progress, but the host platform should be
> good for hosting a cross-compiling LLVM toolchain.
>
>
>
>
> That's probably a bit out of what any of us expected here as the
> typical one is to use build llvm on a platform that it already
> supports. I do agree that default target would also work here as a
> suitable test.
>
> -eric
>
> On Wed, Mar 20, 2019 at 3:47 PM Hubert Tong via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
> >
> > The DWARF debug info unit tests in llvm/unittests/DebugInfo/DWARF/ forms
> a generator based on the host triple. This is problematic for cross-compile
> configurations where LLVM does not fully support code generation for the
> host platform.
> >
> > I have found no rationale for why the host triple was chosen (ref:
> https://reviews.llvm.org/D27326?id=80002#inline-236026).
> >
> > I would imagine that it is more useful to test for the default target
> rather than the host.
> >
> > -- HT
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190321/6cf1b438/attachment.html>


More information about the llvm-dev mailing list