<div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 21, 2019 at 7:55 AM <<a href="mailto:paul.robinson@sony.com">paul.robinson@sony.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div class="gmail-m_6457492072473088004WordSection1">
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">+1. We run a cross-compile environment but as it's the same target architecture as our hosts, we don't run into quite the same issue; but I would like to see
the unittests pay attention to the default target triple.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">Note there are some builds that do not *have* a default target triple, so you'll want to do something sensible there.</span></p></div></div></blockquote><div>Thanks for the tip. I'll keep that in mind.</div><div><br></div><div>-- HT<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-US"><div class="gmail-m_6457492072473088004WordSection1"><p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">--paulr<u></u><u></u></span></p>
<p class="MsoNormal"><a name="m_6457492072473088004__MailEndCompose"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)"><u></u> <u></u></span></a></p>
<div style="border-color:currentcolor currentcolor currentcolor blue;border-style:none none none solid;border-width:medium medium medium 1.5pt;padding:0in 0in 0in 4pt">
<div>
<div style="border-color:rgb(181,196,223) currentcolor currentcolor;border-style:solid none none;border-width:1pt medium medium;padding:3pt 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10pt;font-family:"Tahoma","sans-serif""> llvm-dev [mailto:<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a>]
<b>On Behalf Of </b>Hubert Tong via llvm-dev<br>
<b>Sent:</b> Thursday, March 21, 2019 12:05 AM<br>
<b>To:</b> Eric Christopher<br>
<b>Cc:</b> llvm-dev<br>
<b>Subject:</b> Re: [llvm-dev] DWARF debug info unit tests: Tests for wrong triple?<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<div>
<p class="MsoNormal">On Wed, Mar 20, 2019 at 7:29 PM Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Adding in aprantl here to make sure he's aware.<br>
<br>
Making sure I understand - you're building a compiler on machine a<br>
that llvm doesn't support code generation to and running the llvm<br>
tests on that platform?<u></u><u></u></p>
</blockquote>
<div>
<p class="MsoNormal">Yes, or rather the support is in-progress, but the host platform should be good for hosting a cross-compiling LLVM toolchain.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><br>
That's probably a bit out of what any of us expected here as the<br>
typical one is to use build llvm on a platform that it already<br>
supports. I do agree that default target would also work here as a<br>
suitable test.<br>
<br>
-eric<br>
<br>
On Wed, Mar 20, 2019 at 3:47 PM Hubert Tong via llvm-dev<br>
<<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br>
><br>
> The DWARF debug info unit tests in llvm/unittests/DebugInfo/DWARF/ forms a generator based on the host triple. This is problematic for cross-compile configurations where LLVM does not fully support code generation for the host platform.<br>
><br>
> I have found no rationale for why the host triple was chosen (ref: <a href="https://reviews.llvm.org/D27326?id=80002#inline-236026" target="_blank">
https://reviews.llvm.org/D27326?id=80002#inline-236026</a>).<br>
><br>
> I would imagine that it is more useful to test for the default target rather than the host.<br>
><br>
> -- HT<br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</blockquote></div></div>