[LLVMdev] Request for review: Loss of Sign Checker

Soumitra Chatterjee soumitra at hp.com
Mon Jun 22 22:29:06 PDT 2015


Looks like my submission was incomplete and the id I mentioned was hence 
incorrect. Apologies for that.

I *think* I have now completed the submission correctly on Phabricator 
as #D10634: http://reviews.llvm.org/D10634

Thanks,
Soumitra

On 22-Jun-2015 10:09 AM, Soumitra Chatterjee wrote:
> Hi,
>      I just submitted a patch (Phabricator diff #28096) for a new 'Loss
> of Sign' checker, that would help diagnose the case when a negative
> value is assigned to an unsigned variable. The test case is included.
>
> Unfortunately, there are no existing diagnostics for such assignments
> that lose the sign, which can cause nasty silent runtime failures.
>
> Can someone please review the above changes? Since I do not have commit
> privilege, I would need someone to please help me with committing the
> changes once the review is over.
>
> Please do let me know in case I missed anything.
>
> Thanks,
> Soumitra
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev



More information about the llvm-dev mailing list