[LLVMdev] Request for review: Loss of Sign Checker

[Mehdi Amini]

Hi,

If you follow the instruction here http://llvm.org/docs/Phabricator.html and especially "If your patch is for LLVM, add llvm-commits as a subscriber; if your patch is for Clang, add cfe-commits”, the patch will be sent automatically by phabricator to the correct mailing-list (llvm-commits of cfe-commits).

— 
Mehdi

> On Jun 21, 2015, at 9:39 PM, Soumitra Chatterjee <soumitra at hp.com> wrote:
> 
> Hi,
> 	I just submitted a patch (Phabricator diff #28096) for a new 'Loss of Sign' checker, that would help diagnose the case when a negative value is assigned to an unsigned variable. The test case is included.
> 
> Unfortunately, there are no existing diagnostics for such assignments that lose the sign, which can cause nasty silent runtime failures.
> 
> Can someone please review the above changes? Since I do not have commit privilege, I would need someone to please help me with committing the changes once the review is over.
> 
> Please do let me know in case I missed anything.
> 
> Thanks,
> Soumitra
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev