[LLVMdev] Request for review: Loss of Sign Checker

Evgeny Astigeevich evgeny.astigeevich at arm.com
Mon Jun 22 07:45:40 PDT 2015


Hi Soumitra,

I failed to find your patch #28096 in Phabricator.
Maybe it is a wrong id.

Kind regard,
Evgeny Astigeevich


-----Original Message-----
From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] On
Behalf Of Soumitra Chatterjee
Sent: 22 June 2015 05:39
To: llvmdev at cs.uiuc.edu
Subject: [LLVMdev] Request for review: Loss of Sign Checker

Hi,
	I just submitted a patch (Phabricator diff #28096) for a new 'Loss
of Sign' checker, that would help diagnose the case when a negative value is
assigned to an unsigned variable. The test case is included.

Unfortunately, there are no existing diagnostics for such assignments that
lose the sign, which can cause nasty silent runtime failures.

Can someone please review the above changes? Since I do not have commit
privilege, I would need someone to please help me with committing the
changes once the review is over.

Please do let me know in case I missed anything.

Thanks,
Soumitra
_______________________________________________
LLVM Developers mailing list
LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev







More information about the llvm-dev mailing list