[LLVMdev] [PATCH] Coding standards: don't use ``inline`` when defining a function in a class definition

Chandler Carruth chandlerc at google.com
Mon Feb 4 01:35:52 PST 2013


On Mon, Feb 4, 2013 at 1:31 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Wed, Jan 30, 2013 at 1:08 AM, Dmitri Gribenko <gribozavr at gmail.com>
> wrote:
> > Hello,
> >
> > This came up on IRC in context of r173842, and it was suggested to
> > codify this unspoken rule.
> >
> > Current practice is not to use 'inline' in:
> >
> >   class Foo {
> >   public:
> >     inline void bar() {
> >       // ...
> >     }
> >   };
>
> Ping.
>
> This patch is not changing anything, it just documents the rule we
> already follow.


Sure. LGTM.

Note that I don't have any real opinion about this other than that it's one
less needless keyword. =]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130204/92efa108/attachment.html>


More information about the llvm-dev mailing list