[LLVMdev] Heads up -- take two for renaming VMCore -> IR

Chris Lattner clattner at apple.com
Mon Dec 24 02:49:03 PST 2012


Ok seems reasonable.  The downside is that headers will move twice, but that isn't a big deal I guess.

-Chris

On Dec 24, 2012, at 4:03 AM, Chandler Carruth <chandlerc at gmail.com> wrote:

> On Sun, Dec 23, 2012 at 6:49 PM, Chris Lattner <clattner at apple.com> wrote:
>> Right, I just meant which specific header files should move.  Pass manager doesn't seem like it should, for example.
> 
> lib/VMCore/PassManager.cpp indicates to me that include/llvm/PassManager.h should become include/llvm/IR/PassManager.h
> 
> It feels like what you're really interested in is splitting out non-IR-specific things (like passes) into a separate library. I agree that this would be goodness, but it seems orthogonal to structuring the *files* in the IR library correctly.
> 
> I'd like to solve the file structure given the existing library layering first as a simple and entirely mechanical change.
> 
> I'm then happy to look into how to make a better layering of libraries (and generally make the libraries more fine grained). But that is *not* mechanical, and I don't want to block fixing the naming bits while waiting to figure out the design issue of how best to restructure these libraries.
>  
>> 
>> 
>> -Chris
>> 
>> On Dec 23, 2012, at 8:13 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
>> 
>>> On Sat, Dec 22, 2012 at 9:05 PM, Chris Lattner <clattner at apple.com> wrote:
>>>> Sounds great, thanks Chandler.  In addition to each file being discussed, it would be nice to have a high level plan to kick things off.
>>> 
>>> What exact plan are you looking for?
>>> 
>>> From the original thread:
>>> 
>>> - lib/VMCore -> lib/IR
>>> - include/llvm/Foo.h -> include/llvm/IR/Foo.h (if Foo.h belongs in that library)
>>> 
>>> I didn't have a more detailed plan. ;]
>> 
>> _______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121224/c5f661ba/attachment.html>


More information about the llvm-dev mailing list