<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Ok seems reasonable. The downside is that headers will move twice, but that isn't a big deal I guess.<br><br><div>-Chris</div></div><div><br>On Dec 24, 2012, at 4:03 AM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com">chandlerc@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div style="font-family: arial, helvetica, sans-serif; font-size: 10pt"><div dir="ltr"><div class="gmail_default" style="">On Sun, Dec 23, 2012 at 6:49 PM, Chris Lattner <span dir="ltr"><<a href="mailto:clattner@apple.com" target="_blank" class="cremed">clattner@apple.com</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div>Right, I just meant which specific header files should move. Pass manager doesn't seem like it should, for example.</div>
</div></blockquote><div><br></div><div style="">lib/VMCore/PassManager.cpp indicates to me that include/llvm/PassManager.h should become include/llvm/IR/PassManager.h</div><div style=""><br></div><div style="">It feels like what you're really interested in is splitting out non-IR-specific things (like passes) into a separate library. I agree that this would be goodness, but it seems orthogonal to structuring the *files* in the IR library correctly.</div>
<div style=""><br></div><div style="">I'd like to solve the file structure given the existing library layering first as a simple and entirely mechanical change.</div><div style=""><br></div><div style="">I'm then happy to look into how to make a better layering of libraries (and generally make the libraries more fine grained). But that is *not* mechanical, and I don't want to block fixing the naming bits while waiting to figure out the design issue of how best to restructure these libraries.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div><span class="HOEnZb"><font color="#888888"><br><br><div>-Chris</div></font></span></div>
<div><div class="h5"><div><br>On Dec 23, 2012, at 8:13 AM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" target="_blank" class="cremed">chandlerc@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div>
<div style="font-family:arial,helvetica,sans-serif;font-size:10pt"><div dir="ltr"><div>On Sat, Dec 22, 2012 at 9:05 PM, Chris Lattner <span dir="ltr"><<a href="mailto:clattner@apple.com" target="_blank" class="cremed">clattner@apple.com</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div>Sounds great, thanks Chandler. In addition to each file being discussed, it would be nice to have a high level plan to kick things off.</div>
</div></blockquote><div><br></div><div>What exact plan are you looking for?</div><div><br></div><div>From the original thread:</div><div><br></div><div>- lib/VMCore -> lib/IR</div><div>
- include/llvm/Foo.h -> include/llvm/IR/Foo.h (if Foo.h belongs in that library)</div><div><br></div><div>I didn't have a more detailed plan. ;]</div></div></div></div></div>
</div></blockquote></div></div></div>
<br>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu" class="cremed">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank" class="cremed">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
<br></blockquote></div><br></div></div></div>
</div></blockquote></body></html>