[LLVMdev] MCStreamer interface

[Nathan Jeffords]

Thanks! Funny, I was just preparing a patch to submit for my changes to
MCSectionCOFF. My changes look to be fairly independent of yours, my change
was to deal with COMDAT's. I had dealt with the characteristics flags in the
object writer, but I like this. If you don't mind I would like to merge my
changes into this patch and submit it. I was just pondering how to deal with
the PrintSwitchToSection function without needing the IsDirective flag.

On Thu, May 6, 2010 at 11:12 PM, Peter S. Housel <housel at acm.org> wrote:

> On Wed, 2010-05-05 at 13:22 -0700, Nathan Jeffords wrote:
>
> >
> >         The important point here is that the COFF MCSection needs to
> >         have the right level of semantic information.  In fact,
> >         MCSection is the place that I'd start for COFF bringup.
> >
> > OK, I see that now. The current isolation
> > between TargetLoweringObjectFile -> MCStreamer -> MCObjectWriter has
> > proven somewhat problematic, mostly due to my lack of understanding.
> > I guess MCSectionXXX was meant to provide communication between them.
> > Should the same be true of MCSymbol, and their data counterparts?
>
> I'm enclosing my patch for reforming MCSectionCOFF to match the
> implementation strategy of the other two MCSection classes. You may find
> it useful as a starting point. It seems to be complete and correct, and
> worked for what I tried with it, but I didn't find time to test it fully
> (e.g., by bootstrapping clang under Cygwin).
>
> Cheers,
> -Peter-
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100506/169d6339/attachment.html>