[llvm] [libsycl][Unit] Tighten mock liboffload API argument checks (PR #211035)

Kseniya Tikhomirova via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 03:07:56 PDT 2026


================
@@ -210,12 +189,10 @@ void mock::MockLiboffload::initDefault() {
       .WillByDefault([this](ol_program_handle_t Program, const char *Name,
                             ol_symbol_kind_t Kind,
                             ol_symbol_handle_t *Symbol) -> ol_result_t {
-        if (!Program)
-          return makeEmptyStrError(OL_ERRC_INVALID_NULL_HANDLE);
-        if (!Name || !Symbol)
-          return makeEmptyStrError(OL_ERRC_INVALID_NULL_POINTER);
+        EXPECT_TRUE(Program);
----------------
KseniyaTikhomirova wrote:

nit: I personally think that EXPECT_NE(ptr, nullptr) would be better for such cases, it helps to easily understand the type

https://github.com/llvm/llvm-project/pull/211035


More information about the llvm-commits mailing list