[llvm] [libsycl][Unit] Tighten mock liboffload API argument checks (PR #211035)

[Kseniya Tikhomirova via llvm-commits]

================
@@ -69,70 +68,54 @@ void mock::MockLiboffload::initDefault() {
       .WillByDefault([this](ol_platform_handle_t Platform,
                             ol_platform_info_t PropName,
                             size_t *PropSizeRet) -> ol_result_t {
-        if (!Platform)
-          return makeEmptyStrError(OL_ERRC_INVALID_NULL_HANDLE);
-        if (!PropSizeRet)
-          return makeEmptyStrError(OL_ERRC_INVALID_NULL_POINTER);
-
-        if (PropName == OL_PLATFORM_INFO_BACKEND) {
-          *PropSizeRet = sizeof(ol_platform_backend_t);
-          return OL_SUCCESS;
-        }
+        EXPECT_TRUE(Platform);
+        EXPECT_TRUE(PropSizeRet);
 
-        return makeEmptyStrError(OL_ERRC_UNIMPLEMENTED);
+        EXPECT_EQ(PropName, OL_PLATFORM_INFO_BACKEND);
+        *PropSizeRet = sizeof(ol_platform_backend_t);
+        return OL_SUCCESS;
       });
 
   ON_CALL(*this, olGetPlatformInfo)
       .WillByDefault([this](ol_platform_handle_t Platform,
                             ol_platform_info_t PropName, size_t PropSize,
                             void *PropValue) -> ol_result_t {
-        if (!Platform)
-          return makeEmptyStrError(OL_ERRC_INVALID_NULL_HANDLE);
-        if (!PropSize)
-          return makeEmptyStrError(OL_ERRC_INVALID_SIZE);
-        if (!PropValue)
-          return makeEmptyStrError(OL_ERRC_INVALID_NULL_POINTER);
-
-        if (PropName == OL_PLATFORM_INFO_BACKEND) {
-          if (PropSize != sizeof(ol_platform_backend_t))
-            return makeEmptyStrError(OL_ERRC_INVALID_SIZE);
-          assignAs<ol_platform_backend_t>(PropValue,
-                                          Platform == HostPlatform
-                                              ? OL_PLATFORM_BACKEND_HOST
-                                              : OL_PLATFORM_BACKEND_LEVEL_ZERO);
-          return OL_SUCCESS;
-        }
-
-        return makeEmptyStrError(OL_ERRC_UNIMPLEMENTED);
+        EXPECT_TRUE(Platform);
+        EXPECT_TRUE(PropSize);
+        EXPECT_TRUE(PropValue);
+
+        EXPECT_EQ(PropName, OL_PLATFORM_INFO_BACKEND);
+        EXPECT_EQ(PropSize, sizeof(ol_platform_backend_t));
+        assignAs<ol_platform_backend_t>(PropValue,
+                                        Platform == HostPlatform
+                                            ? OL_PLATFORM_BACKEND_HOST
+                                            : OL_PLATFORM_BACKEND_LEVEL_ZERO);
+        return OL_SUCCESS;
       });
 
   ON_CALL(*this, olGetDeviceInfo)
       .WillByDefault([this](ol_device_handle_t Device,
                             ol_device_info_t PropName, size_t PropSize,
                             void *PropValue) -> ol_result_t {
-        if (!Device)
-          return makeEmptyStrError(OL_ERRC_INVALID_NULL_HANDLE);
-        if (!PropSize)
-          return makeEmptyStrError(OL_ERRC_INVALID_SIZE);
-        if (!PropValue)
-          return makeEmptyStrError(OL_ERRC_INVALID_NULL_POINTER);
+        EXPECT_TRUE(Device);
+        EXPECT_TRUE(PropSize);
+        EXPECT_TRUE(PropValue);
 
         switch (PropName) {
         case OL_DEVICE_INFO_PLATFORM: {
-          if (PropSize != sizeof(ol_platform_handle_t))
-            return makeEmptyStrError(OL_ERRC_INVALID_SIZE);
+          EXPECT_EQ(PropSize, sizeof(ol_platform_handle_t));
           assignAs<ol_platform_handle_t>(
               PropValue, reinterpret_cast<mock::dummy_handle_t>(Device)
                              ->getDataAs<ol_platform_handle_t>());
           return OL_SUCCESS;
         }
         case OL_DEVICE_INFO_TYPE: {
-          if (PropSize != sizeof(ol_device_type_t))
-            return makeEmptyStrError(OL_ERRC_INVALID_SIZE);
+          EXPECT_EQ(PropSize, sizeof(ol_device_type_t));
           assignAs<ol_device_type_t>(PropValue, OL_DEVICE_TYPE_GPU);
           return OL_SUCCESS;
         }
         default:
+          ADD_FAILURE();
----------------
KseniyaTikhomirova wrote:

why not to abort test with FAIL?


https://github.com/llvm/llvm-project/pull/211035