[llvm] [RISCV][CostModel] Fix invalid cost for vector select on targets without FP vector support (PR #183158)

via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 22:39:33 PST 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp b/llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
index 60ae7b942..65fb07889 100644
--- a/llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
+++ b/llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
@@ -2304,8 +2304,8 @@ InstructionCost RISCVTTIImpl::getCmpSelInstrCost(
   std::pair<InstructionCost, MVT> LT = getTypeLegalizationCost(ValTy);
   if (Opcode == Instruction::Select && ValTy->isVectorTy()) {
     // If the target lacks native support for the floating-point vector type,
-    // fall back to BaseT model. This calculates a scalarized cost for fixed vectors,
-    // and correctly returns an Invalid cost for scalable vectors.
+    // fall back to BaseT model. This calculates a scalarized cost for fixed
+    // vectors, and correctly returns an Invalid cost for scalable vectors.
     if (ValTy->isVectorTy() && ValTy->getScalarType()->isFloatingPointTy() &&
         ((ValTy->getScalarSizeInBits() == 16 && !ST->hasVInstructionsF16()) ||
          (ValTy->getScalarSizeInBits() == 32 && !ST->hasVInstructionsF32()) ||

``````````

</details>


https://github.com/llvm/llvm-project/pull/183158


More information about the llvm-commits mailing list