[llvm] [LLVM][Support] Move default values out of the storage (PR #184581)

[via llvm-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 128702 tests passed
* 2945 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/clang/tools/extra/clangd/index/dex/dexp/CMakeFiles/dexp.dir/Dexp.cpp.obj</summary>

```
FAILED: [code=1] tools/clang/tools/extra/clangd/index/dex/dexp/CMakeFiles/dexp.dir/Dexp.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DCLANG_BUILD_STATIC -DLLVM_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\clangd\index\dex\dexp -IC:\_work\llvm-project\llvm-project\clang-tools-extra\clangd\index\dex\dexp -IC:\_work\llvm-project\llvm-project\clang-tools-extra\clangd\..\include-cleaner\include -IC:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\clangd\..\clang-tidy -IC:\_work\llvm-project\llvm-project\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\clang\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\clang-tools-extra\clangd -IC:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\clangd /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\clang\tools\extra\clangd\index\dex\dexp\CMakeFiles\dexp.dir\Dexp.cpp.obj /Fdtools\clang\tools\extra\clangd\index\dex\dexp\CMakeFiles\dexp.dir\ -c -- C:\_work\llvm-project\llvm-project\clang-tools-extra\clangd\index\dex\dexp\Dexp.cpp
C:\_work\llvm-project\llvm-project\clang-tools-extra\clangd\index\dex\dexp\Dexp.cpp(421,17): error: no matching member function for call to 'setValue'
421 |   IndexLocation.setValue(IndexLocation, /*initial=*/true);
|   ~~~~~~~~~~~~~~^~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/CommandLine.h(1399,27): note: candidate function template not viable: requires single argument 'V', but 2 arguments were provided
1399 |   template <class T> void setValue(const T &V) { DataType::operator=(V); }
|                           ^        ~~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang-tools-extra\clangd\index\dex\dexp\Dexp.cpp(422,15): error: no matching member function for call to 'setValue'
422 |   ExecCommand.setValue(ExecCommand, /*initial=*/true);
|   ~~~~~~~~~~~~^~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/CommandLine.h(1399,27): note: candidate function template not viable: requires single argument 'V', but 2 arguments were provided
1399 |   template <class T> void setValue(const T &V) { DataType::operator=(V); }
|                           ^        ~~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang-tools-extra\clangd\index\dex\dexp\Dexp.cpp(423,15): error: no matching member function for call to 'setValue'
423 |   ProjectRoot.setValue(ProjectRoot, /*initial=*/true);
|   ~~~~~~~~~~~~^~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/CommandLine.h(1399,27): note: candidate function template not viable: requires single argument 'V', but 2 arguments were provided
1399 |   template <class T> void setValue(const T &V) { DataType::operator=(V); }
|                           ^        ~~~~~~~~~~
3 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/184581