[llvm] [LLVM][Support] Move default values out of the storage (PR #184581)

[via llvm-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 167464 tests passed
* 3094 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>tools/clang/tools/extra/clangd/index/dex/dexp/CMakeFiles/dexp.dir/Dexp.cpp.o</summary>

```
FAILED: tools/clang/tools/extra/clangd/index/dex/dexp/CMakeFiles/dexp.dir/Dexp.cpp.o
sccache /opt/llvm/bin/clang++ -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/tools/extra/clangd/index/dex/dexp -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang-tools-extra/clangd/index/dex/dexp -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang-tools-extra/clangd/../include-cleaner/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/tools/extra/clangd/../clang-tidy -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang-tools-extra/clangd -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/tools/extra/clangd -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/clang/tools/extra/clangd/index/dex/dexp/CMakeFiles/dexp.dir/Dexp.cpp.o -MF tools/clang/tools/extra/clangd/index/dex/dexp/CMakeFiles/dexp.dir/Dexp.cpp.o.d -o tools/clang/tools/extra/clangd/index/dex/dexp/CMakeFiles/dexp.dir/Dexp.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:421:17: error: no matching member function for call to 'setValue'
421 |   IndexLocation.setValue(IndexLocation, /*initial=*/true);
|   ~~~~~~~~~~~~~~^~~~~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/CommandLine.h:1399:27: note: candidate function template not viable: requires single argument 'V', but 2 arguments were provided
1399 |   template <class T> void setValue(const T &V) { DataType::operator=(V); }
|                           ^        ~~~~~~~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:422:15: error: no matching member function for call to 'setValue'
422 |   ExecCommand.setValue(ExecCommand, /*initial=*/true);
|   ~~~~~~~~~~~~^~~~~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/CommandLine.h:1399:27: note: candidate function template not viable: requires single argument 'V', but 2 arguments were provided
1399 |   template <class T> void setValue(const T &V) { DataType::operator=(V); }
|                           ^        ~~~~~~~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:423:15: error: no matching member function for call to 'setValue'
423 |   ProjectRoot.setValue(ProjectRoot, /*initial=*/true);
|   ~~~~~~~~~~~~^~~~~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/CommandLine.h:1399:27: note: candidate function template not viable: requires single argument 'V', but 2 arguments were provided
1399 |   template <class T> void setValue(const T &V) { DataType::operator=(V); }
|                           ^        ~~~~~~~~~~
3 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/184581