[llvm] [llvm-objdump] Return non-zero exit code for invalid MachO files (PR #172886)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 17 01:07:00 PST 2026


================
@@ -2537,8 +2537,11 @@ void objdump::parseInputMachO(StringRef Filename) {
   if (!BinaryOrErr) {
     if (Error E = isNotObjectErrorInvalidFileType(BinaryOrErr.takeError()))
       reportError(std::move(E), Filename);
-    else
-      outs() << Filename << ": is not an object file\n";
+    else {
----------------
jh7370 wrote:

Nit: LLVM coding standard says if braces are needed for one part of an if/else chain, it should be added to all parts.

https://github.com/llvm/llvm-project/pull/172886


More information about the llvm-commits mailing list