[llvm] [llvm-objdump] Return non-zero exit code for invalid MachO files (PR #172886)

[James Henderson via llvm-commits]

https://github.com/jh7370 commented:

Can I get the motivation for this change, please, including adding it to the PR description? I note in particular that this possibly diverges from the behaviour for other platforms (e.g. ELF) and secondly, there's code in `parseInputMachO` that reports an error under other cases, so not reporting an error here seems like a deliberate design decision. Indeed, reviewing the file history, that looks to be the case: https://github.com/llvm/llvm-project/commit/98898f2b0283629a03e52950da0007bb82b01ef7.

https://github.com/llvm/llvm-project/pull/172886