[libcxx] [llvm] [utils] update how auto-updated tests are displayed when the test is retried (PR #181097)

Henrik G. Olsson via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 13 13:17:31 PST 2026


hnrklssn wrote:

> I think I added `ALLOW_RETRIES` back in the days, and since then my thinking has evolved that this was probably not worth doing. We've actually been refactoring our tests to remove those, and grepping through the monorepo, it seems that there aren't many `ALLOW_RETRIES` tests left anymore. I'm not familiar with that "test updater" is so I think I am missing the whole point of this PR, but in case the only motivation for this change is `ALLOW_RETRIES`, I think it might be better to clean up the few remaining uses of that feature and then not have to do this.

In Swift we enable 5 retries for all tests by default, except for tests known to be time consuming. So this is more about enabling downstream use than for use directly in upstream. In general I do think allowing at least one retry is a nice workflow when using `--update-tests` though, to confirm that the test updates actually fixed the tests properly. I just used `ALLOW_RETRIES` to vary the number of retries per test, rather than `--max-retries-per-test`.

https://github.com/llvm/llvm-project/pull/181097


More information about the llvm-commits mailing list