[llvm] [DA] Ensure nsw flag is checked for StrongSIV addrecs (PR #178047)

[Ehsan Amiri via llvm-commits]

amehsan wrote:

> However, I have to say that, in our discussions about DA, I had _trusted_ that you were very familiar with it. I assumed you had spent a considerable amount of time understanding and/or developing DA, perhaps in your downstream work. Since you have strongly disagreed with me several times, I also assumed those disagreements were grounded in that level of expertise.
> 
> I have to admit that recently I've begun to doubt this, and I’ve been wondering whether you are actually an expert in DA. As a result of this PR (in conjunction with previous discussions), I'm now close to no longer being able to assume such expertise.
> 
> I don't want to blame anyone for being unfamiliar with something, but I _believe_ one's actions should be in line with their level of expertise. I don't _think_ someone at this level has enough capability to _judge_ the rationality of others' PRs or approaches. Of course, commenting on them is welcome, but as in case #162281, dismissing something outright from the start strikes me as overdoing it. Also, explicitly stating "objection" without sufficient experience in the topic seems a bit too much in some cases. In such a situation, I feel it becomes almost impossible to reach a consensus, as continuing the discussion without sufficient knowledge will only lead us nowhere. It may simply end up being a waste of time for everyone involved.
> 
> I think the topic of this PR is a good first issue to start with, and will help you get familiar with the codebase of DA. If you are willing to learn and understand the implementation of DA, please try reading the code and identifying the mistake you made on your own.



this comment is entirely non-technical and off-topic. As I have mentioned multiple times, please keep your comments focused on the relevant technical issues

@nikic @fhahn @arsenm 

https://github.com/llvm/llvm-project/pull/178047