[llvm] [DA] Ensure nsw flag is checked for StrongSIV addrecs (PR #178047)
Ehsan Amiri via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 13 11:48:22 PST 2026
amehsan wrote:
> This change is clearly incorrect... I'll refrain from pointing out where the mistake is, as I think it's a "good first issue" and a useful exercise for you to get familiar with the codebase.
It's possible that there is mistake in the PR. I am not in rush for merging it and I don't mind finding it on my own.
If a reviewer believes a patch is not ready to be merged, it is their responsibility to point out the problem and defend it. A reviewer cannot prevent a patch from merging simply by claiming there exists a problem and not presenting any actionable details.
https://github.com/llvm/llvm-project/pull/178047
More information about the llvm-commits
mailing list