[llvm] [profcheck][test] Use quotes for when not using the internal lit shell (PR #170873)

via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 5 07:48:23 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-pgo

Author: Jordan Rupprecht (rupprecht)

<details>
<summary>Changes</summary>

Using `-passes=function(prof-inject),module(prof-verify)` needs to be quoted when using a non-lit shell.

Fixes tests in 4b4294473280a8e37d818a9362e33544799cb4e4 when not using lit's shell

---
Full diff: https://github.com/llvm/llvm-project/pull/170873.diff


2 Files Affected:

- (modified) llvm/test/Transforms/PGOProfile/prof-verify-known-cold.ll (+1-1) 
- (modified) llvm/test/Transforms/PGOProfile/prof-verify.ll (+1-1) 


``````````diff
diff --git a/llvm/test/Transforms/PGOProfile/prof-verify-known-cold.ll b/llvm/test/Transforms/PGOProfile/prof-verify-known-cold.ll
index 9fa2732fbc6b5..acebc1011d284 100644
--- a/llvm/test/Transforms/PGOProfile/prof-verify-known-cold.ll
+++ b/llvm/test/Transforms/PGOProfile/prof-verify-known-cold.ll
@@ -1,6 +1,6 @@
 ; Test prof-verify for functions explicitly marked as cold
 
-; RUN: opt -passes=function(prof-inject),module(prof-verify) %s -o - 2>&1 | FileCheck %s
+; RUN: opt -passes='function(prof-inject),module(prof-verify)' %s -o - 2>&1 | FileCheck %s
 
 define void @foo(i32 %i) !prof !0 {
   %c = icmp eq i32 %i, 0
diff --git a/llvm/test/Transforms/PGOProfile/prof-verify.ll b/llvm/test/Transforms/PGOProfile/prof-verify.ll
index 90a20b68ab23c..a967378dc652c 100644
--- a/llvm/test/Transforms/PGOProfile/prof-verify.ll
+++ b/llvm/test/Transforms/PGOProfile/prof-verify.ll
@@ -6,7 +6,7 @@
 
 ; RUN: opt -passes=prof-inject %s -S -o - | FileCheck %s --check-prefix=INJECT
 ; RUN: not opt -passes=prof-verify %s -S -o - 2>&1 | FileCheck %s --check-prefix=VERIFY
-; RUN: opt -passes=function(prof-inject),module(prof-verify) %s --disable-output
+; RUN: opt -passes='function(prof-inject),module(prof-verify)' %s --disable-output
 ; RUN: opt -enable-profcheck %s -S -o - | FileCheck %s --check-prefix=INJECT
 
 define void @foo(i32 %i) !prof !0 {

``````````

</details>


https://github.com/llvm/llvm-project/pull/170873


More information about the llvm-commits mailing list