[llvm] [profcheck][test] Use quotes for when not using the internal lit shell (PR #170873)

Jordan Rupprecht via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 5 07:47:50 PST 2025


https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/170873

Using `-passes=function(prof-inject),module(prof-verify)` needs to be quoted when using a non-lit shell.

Fixes tests in 4b4294473280a8e37d818a9362e33544799cb4e4 when not using lit's shell

>From f086a1bddf7b6af0cb505cc70b3c12872312e46d Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht <rupprecht at google.com>
Date: Fri, 5 Dec 2025 07:42:30 -0800
Subject: [PATCH 1/2] Add quotes

---
 llvm/test/Transforms/PGOProfile/prof-verify.ll | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/test/Transforms/PGOProfile/prof-verify.ll b/llvm/test/Transforms/PGOProfile/prof-verify.ll
index 90a20b68ab23c..a967378dc652c 100644
--- a/llvm/test/Transforms/PGOProfile/prof-verify.ll
+++ b/llvm/test/Transforms/PGOProfile/prof-verify.ll
@@ -6,7 +6,7 @@
 
 ; RUN: opt -passes=prof-inject %s -S -o - | FileCheck %s --check-prefix=INJECT
 ; RUN: not opt -passes=prof-verify %s -S -o - 2>&1 | FileCheck %s --check-prefix=VERIFY
-; RUN: opt -passes=function(prof-inject),module(prof-verify) %s --disable-output
+; RUN: opt -passes='function(prof-inject),module(prof-verify)' %s --disable-output
 ; RUN: opt -enable-profcheck %s -S -o - | FileCheck %s --check-prefix=INJECT
 
 define void @foo(i32 %i) !prof !0 {

>From 283ad39401bdac3d850dc57e7a05024654ba6064 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht <rupprecht at google.com>
Date: Fri, 5 Dec 2025 07:46:07 -0800
Subject: [PATCH 2/2] Add quotes to another test

---
 llvm/test/Transforms/PGOProfile/prof-verify-known-cold.ll | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/test/Transforms/PGOProfile/prof-verify-known-cold.ll b/llvm/test/Transforms/PGOProfile/prof-verify-known-cold.ll
index 9fa2732fbc6b5..acebc1011d284 100644
--- a/llvm/test/Transforms/PGOProfile/prof-verify-known-cold.ll
+++ b/llvm/test/Transforms/PGOProfile/prof-verify-known-cold.ll
@@ -1,6 +1,6 @@
 ; Test prof-verify for functions explicitly marked as cold
 
-; RUN: opt -passes=function(prof-inject),module(prof-verify) %s -o - 2>&1 | FileCheck %s
+; RUN: opt -passes='function(prof-inject),module(prof-verify)' %s -o - 2>&1 | FileCheck %s
 
 define void @foo(i32 %i) !prof !0 {
   %c = icmp eq i32 %i, 0



More information about the llvm-commits mailing list