[llvm] [dsymutil] Add option to copy swiftmodules built from interface (PR #165293)

Jonas Devlieghere via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 30 10:49:27 PDT 2025


JDevlieghere wrote:

> FWIW, I was taking @rmaz 's approval as LGTM. I can see why it's not considered as a strong approval (since @adrian-prantl is the domain owner).

Thanks for pointing that out, I hadn't noticed and I blame Github's UI for it. It doesn't show up as approved in the list of PRs, in the PR itself it shows up as a grey checkmark and it's also tucked away under "1 more reviewer" in the side bar. I'm a bit puzzled as to why since he's part of the LLVM org. 

Sorry I missed it. We don't technically require code owners to sign off (though in practice we often do) so you would've been fine to merge with Richard's approval.

https://github.com/llvm/llvm-project/pull/165293


More information about the llvm-commits mailing list