[llvm] [dsymutil] Add option to copy swiftmodules built from interface (PR #165293)
J. Ryan Stinnett via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 30 11:11:30 PDT 2025
jryans wrote:
> Thanks for pointing that out, I hadn't noticed and I blame Github's UI for it. It doesn't show up as approved in the list of PRs, in the PR itself it shows up as a grey checkmark and it's also tucked away under "1 more reviewer" in the side bar. I'm a bit puzzled as to why since he's part of the LLVM org.
I believe the reason GitHub is presenting rmaz's review in this way is that they are a member of the org triagers team, but not the committers team, so they do not have write access to the repo. If they had commit / write access, then their review would appear in green as you were expecting.
https://github.com/llvm/llvm-project/pull/165293
More information about the llvm-commits
mailing list