[llvm] [dsymutil] Add option to copy swiftmodules built from interface (PR #165293)
Roy Shi via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 30 10:35:00 PDT 2025
royitaqi wrote:
**TL;DR: SG. Let's give it another week so that folks (esp. @adrian-prantl) have the time to review.**
> Although I see where you're coming from, I feel obligated to point out that doing so wouldn't be in accordance with our [code review policy](https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted),
Sorry that you had to jump out and stop me. I appreciate it.
I take it as a good chance to refresh my memory about the policy. Actually took me sometime to understand the long English sentences. I think the main spirit is to:
1) allow plenty of time for reviews, and
2) make sure that the "reviewers will almost surely be satisfied with the patch" before merging.
> unless you got someone to LGTM it in the meantime.
FWIW, I was taking @rmaz 's approval as LGTM. I can see why it's not considered as a strong approval (since @adrian-prantl is the domain owner).
> Plus all the reviewers were at the Developer Meeting so giving folks a bit more time seems appropriate. This is really @adrian-prantl's domain in dsymutil so I'd like him to sign off on it. This looks fine to me.
Yep make sense to me, esp. about the Developer Meeting. Would love @adrian-prantl 's review for sure (that's why I requested his review in the first place). Happy to wait.
https://github.com/llvm/llvm-project/pull/165293
More information about the llvm-commits
mailing list