[llvm] [MachO] Move getArchTriple implementation into BinaryFormat. (PR #161468)

Fri Oct 3 23:37:20 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-8-cmake-build-only` running on `rocm-docker-rhel-8` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/24088

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[5036/8097] Creating library symlink lib/libMLIRCAPISMT.so
[5037/8097] Linking CXX shared library lib/libMLIRCAPIExportSMTLIB.so.22.0git
[5038/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOpDefs.cpp.o
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/mlir/test/lib/Dialect/Test/TestOpDefs.cpp: In function ‘llvm::StringLiteral getVisibilityString(mlir::SymbolTable::Visibility)’:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/mlir/test/lib/Dialect/Test/TestOpDefs.cpp:37:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
At global scope:
cc1plus: warning: unrecognized command line option ‘-Wno-deprecated-copy’
[5039/8097] Linking CXX shared library lib/libLLVMCoverage.so.22.0git
FAILED: lib/libLLVMCoverage.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-array-bounds -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMCoverage.so.22.0git -o lib/libLLVMCoverage.so.22.0git lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMapping.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingWriter.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib:"  lib/libLLVMProfileData.so.22.0git  lib/libLLVMObject.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMTargetParser.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib && :
lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o: In function `llvm::coverage::BinaryCoverageReader::create(llvm::MemoryBufferRef, llvm::StringRef, llvm::SmallVectorImpl<std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer> > >&, llvm::StringRef, llvm::SmallVectorImpl<llvm::ArrayRef<unsigned char> >*) [clone .localalias.0]':
CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x223): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x35d): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
collect2: error: ld returned 1 exit status
[5040/8097] Creating library symlink lib/libLLVMAnalysis.so
[5041/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.cpp.o
[5042/8097] Creating library symlink lib/libMLIRCAPIExportSMTLIB.so
[5043/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestTypes.cpp.o
[5044/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestTraits.cpp.o
[5045/8097] Linking CXX shared library lib/libMLIRCAPIMath.so.22.0git
[5046/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestPatterns.cpp.o
[5047/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestDialectInterfaces.cpp.o
[5048/8097] Building CXX object lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MachOPlatform.cpp.o
[5049/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOpsSyntax.cpp.o
[5050/8097] Linking CXX shared library lib/libMLIRTransformUtils.so.22.0git
[5051/8097] Linking CXX shared library lib/libMLIRArithAttrToLLVMConversion.so.22.0git
[5052/8097] Linking CXX shared library lib/libMLIRVCIXDialect.so.22.0git
[5053/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.6.cpp.o
[5054/8097] Linking CXX shared library lib/libMLIRComplexDivisionConversion.so.22.0git
[5055/8097] Linking CXX shared library lib/libMLIRCAPILLVM.so.22.0git
[5056/8097] Linking CXX shared library lib/libMLIRSparseTensorDialect.so.22.0git
[5057/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.1.cpp.o
[5058/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.2.cpp.o
[5059/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.4.cpp.o
[5060/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.5.cpp.o
[5061/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.7.cpp.o
[5062/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.0.cpp.o
[5063/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.3.cpp.o
[5064/8097] Linking CXX shared library lib/libMLIRTargetLLVMIRImport.so.22.0git
[5065/8097] Linking CXX shared library lib/libMLIRXeVMDialect.so.22.0git
[5066/8097] Linking CXX shared library lib/libMLIRMemRefDialect.so.22.0git
[5067/8097] Linking CXX shared library lib/libMLIROpenMPDialect.so.22.0git
[5068/8097] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86AsmPrinter.cpp.o
[5069/8097] Linking CXX shared library lib/libMLIRROCDLDialect.so.22.0git
[5070/8097] Building AMDGPUGenAsmMatcher.inc...
[5071/8097] Building AMDGPUGenRegisterInfo.inc...
[5072/8097] Building AMDGPUGenRegisterBank.inc...
Step 7 (build cmake config) failure: build cmake config (failure)
...
[5036/8097] Creating library symlink lib/libMLIRCAPISMT.so
[5037/8097] Linking CXX shared library lib/libMLIRCAPIExportSMTLIB.so.22.0git
[5038/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOpDefs.cpp.o
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/mlir/test/lib/Dialect/Test/TestOpDefs.cpp: In function ‘llvm::StringLiteral getVisibilityString(mlir::SymbolTable::Visibility)’:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/mlir/test/lib/Dialect/Test/TestOpDefs.cpp:37:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
At global scope:
cc1plus: warning: unrecognized command line option ‘-Wno-deprecated-copy’
[5039/8097] Linking CXX shared library lib/libLLVMCoverage.so.22.0git
FAILED: lib/libLLVMCoverage.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-array-bounds -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMCoverage.so.22.0git -o lib/libLLVMCoverage.so.22.0git lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMapping.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingWriter.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib:"  lib/libLLVMProfileData.so.22.0git  lib/libLLVMObject.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMTargetParser.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib && :
lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o: In function `llvm::coverage::BinaryCoverageReader::create(llvm::MemoryBufferRef, llvm::StringRef, llvm::SmallVectorImpl<std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer> > >&, llvm::StringRef, llvm::SmallVectorImpl<llvm::ArrayRef<unsigned char> >*) [clone .localalias.0]':
CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x223): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x35d): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
collect2: error: ld returned 1 exit status
[5040/8097] Creating library symlink lib/libLLVMAnalysis.so
[5041/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.cpp.o
[5042/8097] Creating library symlink lib/libMLIRCAPIExportSMTLIB.so
[5043/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestTypes.cpp.o
[5044/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestTraits.cpp.o
[5045/8097] Linking CXX shared library lib/libMLIRCAPIMath.so.22.0git
[5046/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestPatterns.cpp.o
[5047/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestDialectInterfaces.cpp.o
[5048/8097] Building CXX object lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MachOPlatform.cpp.o
[5049/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOpsSyntax.cpp.o
[5050/8097] Linking CXX shared library lib/libMLIRTransformUtils.so.22.0git
[5051/8097] Linking CXX shared library lib/libMLIRArithAttrToLLVMConversion.so.22.0git
[5052/8097] Linking CXX shared library lib/libMLIRVCIXDialect.so.22.0git
[5053/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.6.cpp.o
[5054/8097] Linking CXX shared library lib/libMLIRComplexDivisionConversion.so.22.0git
[5055/8097] Linking CXX shared library lib/libMLIRCAPILLVM.so.22.0git
[5056/8097] Linking CXX shared library lib/libMLIRSparseTensorDialect.so.22.0git
[5057/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.1.cpp.o
[5058/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.2.cpp.o
[5059/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.4.cpp.o
[5060/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.5.cpp.o
[5061/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.7.cpp.o
[5062/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.0.cpp.o
[5063/8097] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.3.cpp.o
[5064/8097] Linking CXX shared library lib/libMLIRTargetLLVMIRImport.so.22.0git
[5065/8097] Linking CXX shared library lib/libMLIRXeVMDialect.so.22.0git
[5066/8097] Linking CXX shared library lib/libMLIRMemRefDialect.so.22.0git
[5067/8097] Linking CXX shared library lib/libMLIROpenMPDialect.so.22.0git
[5068/8097] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86AsmPrinter.cpp.o
[5069/8097] Linking CXX shared library lib/libMLIRROCDLDialect.so.22.0git
[5070/8097] Building AMDGPUGenAsmMatcher.inc...
[5071/8097] Building AMDGPUGenRegisterInfo.inc...
[5072/8097] Building AMDGPUGenRegisterBank.inc...

```

</details>

https://github.com/llvm/llvm-project/pull/161468