[llvm] [MachO] Move getArchTriple implementation into BinaryFormat. (PR #161468)

Fri Oct 3 23:37:58 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-9-cmake-build-only` running on `rocm-docker-rhel-9` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/24065

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[5377/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/TextNodeDumper.cpp.o
[5378/8097] Creating library symlink lib/libLLVMTarget.so
[5379/8097] Linking CXX shared library lib/libMLIRTransformDialect.so.22.0git
[5380/8097] Linking CXX shared library lib/libLLVMBitWriter.so.22.0git
[5381/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/Type.cpp.o
[5382/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/TypeLoc.cpp.o
[5383/8097] Linking CXX executable bin/llvm-tli-checker
[5384/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/VTableBuilder.cpp.o
[5385/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/VTTBuilder.cpp.o
[5386/8097] Linking CXX shared library lib/libLLVMCoverage.so.22.0git
FAILED: lib/libLLVMCoverage.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMCoverage.so.22.0git -o lib/libLLVMCoverage.so.22.0git lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMapping.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingWriter.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib:"  lib/libLLVMProfileData.so.22.0git  lib/libLLVMObject.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMTargetParser.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib && :
/usr/bin/ld: lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o: in function `llvm::coverage::BinaryCoverageReader::create(llvm::MemoryBufferRef, llvm::StringRef, llvm::SmallVectorImpl<std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer> > >&, llvm::StringRef, llvm::SmallVectorImpl<llvm::ArrayRef<unsigned char> >*) [clone .localalias]':
CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x23a): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
/usr/bin/ld: CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x38a): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
collect2: error: ld returned 1 exit status
[5387/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/TypePrinter.cpp.o
[5388/8097] Creating library symlink lib/libMLIRTransformDialect.so
[5389/8097] Creating library symlink lib/libLLVMBitWriter.so
[5390/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGBlocks.cpp.o
[5391/8097] Linking CXX shared library lib/libMLIRControlFlowTestPasses.so.22.0git
[5392/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGCUDANV.cpp.o
[5393/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/ABIInfo.cpp.o
[5394/8097] Linking CXX shared library lib/libLLVMSandboxIR.so.22.0git
[5395/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/ABIInfoImpl.cpp.o
[5396/8097] Linking CXX shared library lib/libMLIRAMXTransforms.so.22.0git
[5397/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGAtomic.cpp.o
[5398/8097] Building CXX object tools/clang/lib/CrossTU/CMakeFiles/obj.clangCrossTU.dir/CrossTranslationUnit.cpp.o
[5399/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGBuiltin.cpp.o
[5400/8097] Linking CXX shared library lib/libMLIRTensorDialect.so.22.0git
[5401/8097] Linking CXX shared library lib/libMLIRCAPIOpenMP.so.22.0git
[5402/8097] Building OpenCLBuiltins.inc...
[5403/8097] Linking CXX shared library lib/libLLVMExecutionEngine.so.22.0git
[5404/8097] Linking CXX shared library lib/libMLIRGPUUtils.so.22.0git
[5405/8097] Linking CXX shared library lib/libMLIRMemRefToLLVM.so.22.0git
[5406/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/Expr.cpp.o
[5407/8097] Linking CXX shared library lib/libMLIROpenACCTransforms.so.22.0git
[5408/8097] Linking CXX shared library lib/libMLIRXeVMToLLVM.so.22.0git
[5409/8097] Linking CXX shared library lib/libLLVMTransformUtils.so.22.0git
[5410/8097] Linking CXX shared library lib/libMLIRNVGPUDialect.so.22.0git
[5411/8097] Linking CXX shared library lib/libMLIRROCDLDialect.so.22.0git
[5412/8097] Linking CXX shared library lib/libMLIRNVVMDialect.so.22.0git
[5413/8097] Building CXX object lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MachOPlatform.cpp.o
[5414/8097] Building AMDGPUGenInstrInfo.inc...
[5415/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/BackendUtil.cpp.o
[5416/8097] Linking CXX shared library lib/libMLIRSPIRVDialect.so.22.0git
[5417/8097] Building AMDGPUGenAsmMatcher.inc...
[5418/8097] Building AMDGPUGenRegisterInfo.inc...
[5419/8097] Building AMDGPUGenRegisterBank.inc...
Step 7 (build cmake config) failure: build cmake config (failure)
...
[5377/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/TextNodeDumper.cpp.o
[5378/8097] Creating library symlink lib/libLLVMTarget.so
[5379/8097] Linking CXX shared library lib/libMLIRTransformDialect.so.22.0git
[5380/8097] Linking CXX shared library lib/libLLVMBitWriter.so.22.0git
[5381/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/Type.cpp.o
[5382/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/TypeLoc.cpp.o
[5383/8097] Linking CXX executable bin/llvm-tli-checker
[5384/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/VTableBuilder.cpp.o
[5385/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/VTTBuilder.cpp.o
[5386/8097] Linking CXX shared library lib/libLLVMCoverage.so.22.0git
FAILED: lib/libLLVMCoverage.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMCoverage.so.22.0git -o lib/libLLVMCoverage.so.22.0git lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMapping.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingWriter.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib:"  lib/libLLVMProfileData.so.22.0git  lib/libLLVMObject.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMTargetParser.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib && :
/usr/bin/ld: lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o: in function `llvm::coverage::BinaryCoverageReader::create(llvm::MemoryBufferRef, llvm::StringRef, llvm::SmallVectorImpl<std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer> > >&, llvm::StringRef, llvm::SmallVectorImpl<llvm::ArrayRef<unsigned char> >*) [clone .localalias]':
CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x23a): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
/usr/bin/ld: CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x38a): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
collect2: error: ld returned 1 exit status
[5387/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/TypePrinter.cpp.o
[5388/8097] Creating library symlink lib/libMLIRTransformDialect.so
[5389/8097] Creating library symlink lib/libLLVMBitWriter.so
[5390/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGBlocks.cpp.o
[5391/8097] Linking CXX shared library lib/libMLIRControlFlowTestPasses.so.22.0git
[5392/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGCUDANV.cpp.o
[5393/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/ABIInfo.cpp.o
[5394/8097] Linking CXX shared library lib/libLLVMSandboxIR.so.22.0git
[5395/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/ABIInfoImpl.cpp.o
[5396/8097] Linking CXX shared library lib/libMLIRAMXTransforms.so.22.0git
[5397/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGAtomic.cpp.o
[5398/8097] Building CXX object tools/clang/lib/CrossTU/CMakeFiles/obj.clangCrossTU.dir/CrossTranslationUnit.cpp.o
[5399/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGBuiltin.cpp.o
[5400/8097] Linking CXX shared library lib/libMLIRTensorDialect.so.22.0git
[5401/8097] Linking CXX shared library lib/libMLIRCAPIOpenMP.so.22.0git
[5402/8097] Building OpenCLBuiltins.inc...
[5403/8097] Linking CXX shared library lib/libLLVMExecutionEngine.so.22.0git
[5404/8097] Linking CXX shared library lib/libMLIRGPUUtils.so.22.0git
[5405/8097] Linking CXX shared library lib/libMLIRMemRefToLLVM.so.22.0git
[5406/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/Expr.cpp.o
[5407/8097] Linking CXX shared library lib/libMLIROpenACCTransforms.so.22.0git
[5408/8097] Linking CXX shared library lib/libMLIRXeVMToLLVM.so.22.0git
[5409/8097] Linking CXX shared library lib/libLLVMTransformUtils.so.22.0git
[5410/8097] Linking CXX shared library lib/libMLIRNVGPUDialect.so.22.0git
[5411/8097] Linking CXX shared library lib/libMLIRROCDLDialect.so.22.0git
[5412/8097] Linking CXX shared library lib/libMLIRNVVMDialect.so.22.0git
[5413/8097] Building CXX object lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MachOPlatform.cpp.o
[5414/8097] Building AMDGPUGenInstrInfo.inc...
[5415/8097] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/BackendUtil.cpp.o
[5416/8097] Linking CXX shared library lib/libMLIRSPIRVDialect.so.22.0git
[5417/8097] Building AMDGPUGenAsmMatcher.inc...
[5418/8097] Building AMDGPUGenRegisterInfo.inc...
[5419/8097] Building AMDGPUGenRegisterBank.inc...

```

</details>

https://github.com/llvm/llvm-project/pull/161468