[llvm] [MachO] Move getArchTriple implementation into BinaryFormat. (PR #161468)

Fri Oct 3 23:36:20 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-ubuntu-22-cmake-build-only` running on `rocm-docker-ubu-22` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/203/builds/25276

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[5270/8097] Linking CXX shared library lib/libMLIRROCDLDialect.so.22.0git
[5271/8097] Linking CXX shared library lib/libMLIRSCFDialect.so.22.0git
[5272/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTDumper.cpp.o
[5273/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTContext.cpp.o
[5274/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTDiagnostic.cpp.o
[5275/8097] Creating library symlink lib/libMLIROpenACCDialect.so
[5276/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTImporter.cpp.o
[5277/8097] Creating library symlink lib/libMLIRROCDLDialect.so
[5278/8097] Creating library symlink lib/libMLIRSCFDialect.so
[5279/8097] Linking CXX shared library lib/libLLVMCoverage.so.22.0git
FAILED: lib/libLLVMCoverage.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMCoverage.so.22.0git -o lib/libLLVMCoverage.so.22.0git lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMapping.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingWriter.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/lib:"  lib/libLLVMProfileData.so.22.0git  lib/libLLVMObject.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMTargetParser.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/lib && :
/usr/bin/ld: lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o: in function `llvm::coverage::BinaryCoverageReader::create(llvm::MemoryBufferRef, llvm::StringRef, llvm::SmallVectorImpl<std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer> > >&, llvm::StringRef, llvm::SmallVectorImpl<llvm::ArrayRef<unsigned char> >*) [clone .localalias]':
CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x264): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
/usr/bin/ld: CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x3b2): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
collect2: error: ld returned 1 exit status
[5280/8097] Linking CXX shared library lib/libMLIRCAPIMemRef.so.22.0git
[5281/8097] Linking CXX shared library lib/libMLIRFuncShardingExtensions.so.22.0git
[5282/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTConcept.cpp.o
[5283/8097] Linking CXX shared library lib/libMLIRCAPIMLProgram.so.22.0git
[5284/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTImporterLookupTable.cpp.o
[5285/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTStructuralEquivalence.cpp.o
[5286/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTTypeTraits.cpp.o
[5287/8097] Linking CXX shared library lib/libMLIRTensorShardingExtensions.so.22.0git
[5288/8097] Linking CXX shared library lib/libMLIRCAPITensor.so.22.0git
[5289/8097] Linking CXX shared library lib/libMLIRCAPIOpenMP.so.22.0git
[5290/8097] Linking CXX shared library lib/libMLIRShapeDialect.so.22.0git
[5291/8097] Linking CXX shared library lib/libMLIRTransformDialect.so.22.0git
[5292/8097] Linking CXX shared library lib/libMLIRLLVMIRToLLVMTranslation.so.22.0git
[5293/8097] Linking CXX shared library lib/libMLIRAMXTransforms.so.22.0git
[5294/8097] Linking CXX shared library lib/libMLIRCAPINVGPU.so.22.0git
[5295/8097] Linking CXX shared library lib/libMLIRX86VectorDialect.so.22.0git
[5296/8097] Linking CXX shared library lib/libLLVMAnalysis.so.22.0git
[5297/8097] Linking CXX shared library lib/libMLIRControlFlowTestPasses.so.22.0git
[5298/8097] Linking CXX shared library lib/libMLIROpenACCTransforms.so.22.0git
[5299/8097] Linking CXX shared library lib/libMLIRControlFlowToSCF.so.22.0git
[5300/8097] Linking CXX shared library lib/libMLIRCAPIROCDL.so.22.0git
[5301/8097] Linking CXX shared library lib/libMLIRVectorDialect.so.22.0git
[5302/8097] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86AsmPrinter.cpp.o
[5303/8097] Linking CXX shared library lib/libMLIRTosaDialect.so.22.0git
[5304/8097] Linking CXX shared library lib/libMLIRNVVMDialect.so.22.0git
[5305/8097] Building CXX object lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MachOPlatform.cpp.o
[5306/8097] Linking CXX shared library lib/libMLIRSPIRVDialect.so.22.0git
[5307/8097] Building AMDGPUGenInstrInfo.inc...
[5308/8097] Building CXX object tools/obj2yaml/CMakeFiles/obj2yaml.dir/macho2yaml.cpp.o
[5309/8097] Building AMDGPUGenAsmMatcher.inc...
[5310/8097] Building AMDGPUGenRegisterInfo.inc...
[5311/8097] Building AMDGPUGenRegisterBank.inc...
[5312/8097] Building CXX object tools/clang/lib/ExtractAPI/CMakeFiles/obj.clangExtractAPI.dir/ExtractAPIConsumer.cpp.o
Step 7 (build cmake config) failure: build cmake config (failure)
...
[5270/8097] Linking CXX shared library lib/libMLIRROCDLDialect.so.22.0git
[5271/8097] Linking CXX shared library lib/libMLIRSCFDialect.so.22.0git
[5272/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTDumper.cpp.o
[5273/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTContext.cpp.o
[5274/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTDiagnostic.cpp.o
[5275/8097] Creating library symlink lib/libMLIROpenACCDialect.so
[5276/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTImporter.cpp.o
[5277/8097] Creating library symlink lib/libMLIRROCDLDialect.so
[5278/8097] Creating library symlink lib/libMLIRSCFDialect.so
[5279/8097] Linking CXX shared library lib/libLLVMCoverage.so.22.0git
FAILED: lib/libLLVMCoverage.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMCoverage.so.22.0git -o lib/libLLVMCoverage.so.22.0git lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMapping.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingWriter.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/lib:"  lib/libLLVMProfileData.so.22.0git  lib/libLLVMObject.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMTargetParser.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/lib && :
/usr/bin/ld: lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o: in function `llvm::coverage::BinaryCoverageReader::create(llvm::MemoryBufferRef, llvm::StringRef, llvm::SmallVectorImpl<std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer> > >&, llvm::StringRef, llvm::SmallVectorImpl<llvm::ArrayRef<unsigned char> >*) [clone .localalias]':
CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x264): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
/usr/bin/ld: CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x3b2): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
collect2: error: ld returned 1 exit status
[5280/8097] Linking CXX shared library lib/libMLIRCAPIMemRef.so.22.0git
[5281/8097] Linking CXX shared library lib/libMLIRFuncShardingExtensions.so.22.0git
[5282/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTConcept.cpp.o
[5283/8097] Linking CXX shared library lib/libMLIRCAPIMLProgram.so.22.0git
[5284/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTImporterLookupTable.cpp.o
[5285/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTStructuralEquivalence.cpp.o
[5286/8097] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTTypeTraits.cpp.o
[5287/8097] Linking CXX shared library lib/libMLIRTensorShardingExtensions.so.22.0git
[5288/8097] Linking CXX shared library lib/libMLIRCAPITensor.so.22.0git
[5289/8097] Linking CXX shared library lib/libMLIRCAPIOpenMP.so.22.0git
[5290/8097] Linking CXX shared library lib/libMLIRShapeDialect.so.22.0git
[5291/8097] Linking CXX shared library lib/libMLIRTransformDialect.so.22.0git
[5292/8097] Linking CXX shared library lib/libMLIRLLVMIRToLLVMTranslation.so.22.0git
[5293/8097] Linking CXX shared library lib/libMLIRAMXTransforms.so.22.0git
[5294/8097] Linking CXX shared library lib/libMLIRCAPINVGPU.so.22.0git
[5295/8097] Linking CXX shared library lib/libMLIRX86VectorDialect.so.22.0git
[5296/8097] Linking CXX shared library lib/libLLVMAnalysis.so.22.0git
[5297/8097] Linking CXX shared library lib/libMLIRControlFlowTestPasses.so.22.0git
[5298/8097] Linking CXX shared library lib/libMLIROpenACCTransforms.so.22.0git
[5299/8097] Linking CXX shared library lib/libMLIRControlFlowToSCF.so.22.0git
[5300/8097] Linking CXX shared library lib/libMLIRCAPIROCDL.so.22.0git
[5301/8097] Linking CXX shared library lib/libMLIRVectorDialect.so.22.0git
[5302/8097] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86AsmPrinter.cpp.o
[5303/8097] Linking CXX shared library lib/libMLIRTosaDialect.so.22.0git
[5304/8097] Linking CXX shared library lib/libMLIRNVVMDialect.so.22.0git
[5305/8097] Building CXX object lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MachOPlatform.cpp.o
[5306/8097] Linking CXX shared library lib/libMLIRSPIRVDialect.so.22.0git
[5307/8097] Building AMDGPUGenInstrInfo.inc...
[5308/8097] Building CXX object tools/obj2yaml/CMakeFiles/obj2yaml.dir/macho2yaml.cpp.o
[5309/8097] Building AMDGPUGenAsmMatcher.inc...
[5310/8097] Building AMDGPUGenRegisterInfo.inc...
[5311/8097] Building AMDGPUGenRegisterBank.inc...
[5312/8097] Building CXX object tools/clang/lib/ExtractAPI/CMakeFiles/obj.clangExtractAPI.dir/ExtractAPIConsumer.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/161468