[llvm] [MachO] Move getArchTriple implementation into BinaryFormat. (PR #161468)

Fri Oct 3 23:35:52 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `llvm` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/14784

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (compile-openmp) failure: build (failure)
...
11.029 [787/64/3895] Building CXX object tools/clang/lib/StaticAnalyzer/Checkers/CMakeFiles/obj.clangStaticAnalyzerCheckers.dir/WebKit/RefCntblBaseVirtualDtorChecker.cpp.o
11.030 [786/64/3896] Building CXX object tools/llvm-pdbutil/CMakeFiles/llvm-pdbutil.dir/StreamUtil.cpp.o
11.031 [785/64/3897] Building CXX object tools/llvm-rust-demangle-fuzzer/CMakeFiles/llvm-rust-demangle-fuzzer.dir/DummyDemanglerFuzzer.cpp.o
11.032 [784/64/3898] Building CXX object tools/llvm-pdbutil/CMakeFiles/llvm-pdbutil.dir/TypeReferenceTracker.cpp.o
11.033 [783/64/3899] Building CXX object tools/llvm-pdbutil/CMakeFiles/llvm-pdbutil.dir/YAMLOutputStyle.cpp.o
11.033 [782/64/3900] Generating ../../bin/llvm-readelf
11.034 [781/64/3901] Building CXX object tools/llvm-special-case-list-fuzzer/CMakeFiles/llvm-special-case-list-fuzzer.dir/DummySpecialCaseListFuzzer.cpp.o
11.034 [780/64/3902] Building CXX object tools/llvm-rust-demangle-fuzzer/CMakeFiles/llvm-rust-demangle-fuzzer.dir/llvm-rust-demangle-fuzzer.cpp.o
11.035 [779/64/3903] Building CXX object tools/clang/lib/StaticAnalyzer/Frontend/CMakeFiles/obj.clangStaticAnalyzerFrontend.dir/ModelInjector.cpp.o
11.036 [778/64/3904] Linking CXX shared library lib/libLLVMCoverage.so.22.0git
FAILED: lib/libLLVMCoverage.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMCoverage.so.22.0git -o lib/libLLVMCoverage.so.22.0git lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMapping.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingWriter.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/lib:"  lib/libLLVMProfileData.so.22.0git  lib/libLLVMObject.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMTargetParser.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/lib && :
/usr/bin/ld: lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o: in function `llvm::coverage::BinaryCoverageReader::create(llvm::MemoryBufferRef, llvm::StringRef, llvm::SmallVectorImpl<std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer> > >&, llvm::StringRef, llvm::SmallVectorImpl<llvm::ArrayRef<unsigned char> >*) [clone .localalias]':
CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x264): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
/usr/bin/ld: CoverageMappingReader.cpp:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x3b2): undefined reference to `llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
collect2: error: ld returned 1 exit status
11.037 [778/63/3905] Building CXX object tools/llvm-size/CMakeFiles/llvm-size.dir/llvm-size-driver.cpp.o
11.037 [778/62/3906] Linking CXX executable bin/llvm-microsoft-demangle-fuzzer
11.037 [778/61/3907] Building CXX object tools/llvm-special-case-list-fuzzer/CMakeFiles/llvm-special-case-list-fuzzer.dir/special-case-list-fuzzer.cpp.o
11.038 [778/60/3908] Linking CXX executable bin/llvm-itanium-demangle-fuzzer
11.040 [778/59/3909] Building CXX object tools/llvm-sim/CMakeFiles/llvm-sim.dir/llvm-sim.cpp.o
11.041 [778/58/3910] Building CXX object tools/llvm-symbolizer/CMakeFiles/llvm-symbolizer.dir/llvm-symbolizer-driver.cpp.o
11.042 [778/57/3911] Building CXX object tools/llvm-stress/CMakeFiles/llvm-stress.dir/llvm-stress.cpp.o
11.042 [778/56/3912] Building CXX object tools/llvm-strings/CMakeFiles/llvm-strings.dir/llvm-strings.cpp.o
11.042 [778/55/3913] Linking CXX executable bin/llvm-jitlink-executor
11.044 [778/54/3914] Building CXX object tools/llvm-symbolizer/CMakeFiles/llvm-symbolizer.dir/llvm-symbolizer.cpp.o
11.048 [778/53/3915] Building CXX object tools/llvm-tli-checker/CMakeFiles/llvm-tli-checker.dir/llvm-tli-checker.cpp.o
11.061 [778/52/3916] Linking CXX executable bin/llvm-ir2vec
11.066 [778/51/3917] Linking CXX executable bin/llvm-modextract
11.071 [778/50/3918] Building CXX object tools/clang/lib/StaticAnalyzer/Checkers/CMakeFiles/obj.clangStaticAnalyzerCheckers.dir/WebKit/MemoryUnsafeCastChecker.cpp.o
11.071 [778/49/3919] Linking CXX executable bin/llvm-gpu-loader
11.082 [778/48/3920] Building CXX object tools/clang/lib/StaticAnalyzer/Checkers/CMakeFiles/obj.clangStaticAnalyzerCheckers.dir/WebKit/RetainPtrCtorAdoptChecker.cpp.o
11.084 [778/47/3921] Linking CXX executable bin/llvm-offload-wrapper
11.084 [778/46/3922] Linking CXX executable bin/llvm-diff
11.086 [778/45/3923] Linking CXX executable bin/llvm-rust-demangle-fuzzer
11.088 [778/44/3924] Building CXX object tools/clang/lib/StaticAnalyzer/Checkers/CMakeFiles/obj.clangStaticAnalyzerCheckers.dir/WebKit/ForwardDeclChecker.cpp.o
11.096 [778/43/3925] Building AMDGPUGenMCCodeEmitter.inc...
11.133 [778/42/3926] Building CXX object tools/clang/tools/clang-fuzzer/handle-cxx/CMakeFiles/obj.clangHandleCXX.dir/handle_cxx.cpp.o
11.145 [778/41/3927] Building CXX object tools/clang/tools/clang-diff/CMakeFiles/clang-diff.dir/ClangDiff.cpp.o
11.152 [778/40/3928] Building CXX object tools/clang/tools/clang-import-test/CMakeFiles/clang-import-test.dir/clang-import-test.cpp.o
11.160 [778/39/3929] Linking CXX executable bin/llvm-pdbutil
11.162 [778/38/3930] Building CXX object tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/CodeCompletion.cpp.o
11.191 [778/37/3931] Building CXX object tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/IncrementalAction.cpp.o
In file included from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/lib/Interpreter/IncrementalAction.cpp:9:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/lib/Interpreter/IncrementalAction.h:37:38: warning: ‘maybe_unused’ attribute ignored [-Wattributes]
   37 |   [[maybe_unused]] CompilerInstance &CI;
      |                                      ^~
11.194 [778/36/3932] Linking CXX shared library lib/libclangBasic.so.22.0git
11.230 [778/35/3933] Building CXX object tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/IncrementalParser.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/161468