[llvm] Revert "[NFC][SampleFDO] In text sample prof reader, report dreport more concrete parsing errors for different line types" (PR #155121)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 23 14:44:18 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-pgo
Author: Mingming Liu (mingmingl-llvm)
<details>
<summary>Changes</summary>
Reverts llvm/llvm-project#<!-- -->154885 to fix build bot failure (https://lab.llvm.org/buildbot/#/builders/144/builds/33611)
---
Full diff: https://github.com/llvm/llvm-project/pull/155121.diff
1 Files Affected:
- (modified) llvm/lib/ProfileData/SampleProfReader.cpp (+3-10)
``````````diff
diff --git a/llvm/lib/ProfileData/SampleProfReader.cpp b/llvm/lib/ProfileData/SampleProfReader.cpp
index 15eb1d174d6fa..d147222fe2ce6 100644
--- a/llvm/lib/ProfileData/SampleProfReader.cpp
+++ b/llvm/lib/ProfileData/SampleProfReader.cpp
@@ -382,16 +382,9 @@ std::error_code SampleProfileReaderText::readImpl() {
if (!ParseLine(*LineIt, LineTy, Depth, NumSamples, LineOffset,
Discriminator, FName, TargetCountMap, FunctionHash,
Attributes, IsFlat)) {
- switch (LineTy) {
- case LineType::Metadata:
- reportError(LineIt.line_number(),
- "Cannot parse metadata: " + *LineIt);
- break;
- default:
- reportError(LineIt.line_number(),
- "Expected 'NUM[.NUM]: NUM[ mangled_name:NUM]*', found " +
- *LineIt);
- }
+ reportError(LineIt.line_number(),
+ "Expected 'NUM[.NUM]: NUM[ mangled_name:NUM]*', found " +
+ *LineIt);
return sampleprof_error::malformed;
}
if (LineTy != LineType::Metadata && Depth == DepthMetadata) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/155121
More information about the llvm-commits
mailing list