[llvm] ebac9f4 - Revert "[NFC][SampleFDO] In text sample prof reader, report dreport more concrete parsing errors for different line types" (#155121)

via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 23 14:43:58 PDT 2025


Author: Mingming Liu
Date: 2025-08-23T14:43:55-07:00
New Revision: ebac9f4338592dbf83767ff229e6f219c73bb6b9

URL: https://github.com/llvm/llvm-project/commit/ebac9f4338592dbf83767ff229e6f219c73bb6b9
DIFF: https://github.com/llvm/llvm-project/commit/ebac9f4338592dbf83767ff229e6f219c73bb6b9.diff

LOG: Revert "[NFC][SampleFDO] In text sample prof reader, report dreport more concrete parsing errors for different line types" (#155121)

Reverts llvm/llvm-project#154885 to fix build bot failure
(https://lab.llvm.org/buildbot/#/builders/144/builds/33611)

Added: 
    

Modified: 
    llvm/lib/ProfileData/SampleProfReader.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ProfileData/SampleProfReader.cpp b/llvm/lib/ProfileData/SampleProfReader.cpp
index 15eb1d174d6fa..d147222fe2ce6 100644
--- a/llvm/lib/ProfileData/SampleProfReader.cpp
+++ b/llvm/lib/ProfileData/SampleProfReader.cpp
@@ -382,16 +382,9 @@ std::error_code SampleProfileReaderText::readImpl() {
       if (!ParseLine(*LineIt, LineTy, Depth, NumSamples, LineOffset,
                      Discriminator, FName, TargetCountMap, FunctionHash,
                      Attributes, IsFlat)) {
-        switch (LineTy) {
-        case LineType::Metadata:
-          reportError(LineIt.line_number(),
-                      "Cannot parse metadata: " + *LineIt);
-          break;
-        default:
-          reportError(LineIt.line_number(),
-                      "Expected 'NUM[.NUM]: NUM[ mangled_name:NUM]*', found " +
-                          *LineIt);
-        }
+        reportError(LineIt.line_number(),
+                    "Expected 'NUM[.NUM]: NUM[ mangled_name:NUM]*', found " +
+                        *LineIt);
         return sampleprof_error::malformed;
       }
       if (LineTy != LineType::Metadata && Depth == DepthMetadata) {


        


More information about the llvm-commits mailing list