[llvm] [NFC][PGO] Factor downscaling of branch weights out of `Instrumentation` into `ProfileData` (PR #153735)

Thu Aug 14 22:48:21 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `ml-opt-devrel-x86-64` running on `ml-opt-devrel-x86-64-b1` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/175/builds/23450

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
16.118 [2813/64/1056] Building CXX object lib/DebugInfo/Symbolize/CMakeFiles/LLVMSymbolize.dir/DIPrinter.cpp.o
16.127 [2812/64/1057] Building CXX object lib/DebugInfo/Symbolize/CMakeFiles/LLVMSymbolize.dir/Markup.cpp.o
16.139 [2811/64/1058] Building CXX object lib/DebugInfo/Symbolize/CMakeFiles/LLVMSymbolize.dir/MarkupFilter.cpp.o
16.151 [2810/64/1059] Building CXX object lib/DebugInfo/Symbolize/CMakeFiles/LLVMSymbolize.dir/SymbolizableObjectFile.cpp.o
16.159 [2809/64/1060] Building CXX object lib/DebugInfo/Symbolize/CMakeFiles/LLVMSymbolize.dir/Symbolize.cpp.o
16.179 [2808/64/1061] Building CXX object lib/DWARFCFIChecker/CMakeFiles/LLVMDWARFCFIChecker.dir/DWARFCFIAnalysis.cpp.o
16.195 [2807/64/1062] Building CXX object lib/DWARFCFIChecker/CMakeFiles/LLVMDWARFCFIChecker.dir/DWARFCFIFunctionFrameAnalyzer.cpp.o
16.215 [2806/64/1063] Building CXX object lib/DWARFCFIChecker/CMakeFiles/LLVMDWARFCFIChecker.dir/DWARFCFIFunctionFrameStreamer.cpp.o
16.223 [2805/64/1064] Building CXX object lib/DWARFCFIChecker/CMakeFiles/LLVMDWARFCFIChecker.dir/DWARFCFIState.cpp.o
16.231 [2804/64/1065] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o
FAILED: lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/ml-opt-devrel-x86-64-b1/build/lib/IR -I/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/IR -I/var/lib/buildbot/.local/lib/python3.7/site-packages/tensorflow/include -I/b/ml-opt-devrel-x86-64-b1/build/include -I/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o -MF lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o.d -o lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o -c /b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/IR/ProfDataUtils.cpp
/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/IR/ProfDataUtils.cpp: In function ‘llvm::SmallVector<unsigned int> llvm::downscaleWeights(ArrayRef<long unsigned int>, std::optional<long unsigned int>)’:
/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/IR/ProfDataUtils.cpp:282:10: error: could not convert ‘DownscaledWeights’ from ‘SmallVector<[...],4>’ to ‘SmallVector<[...],12>’
  282 |   return DownscaledWeights;
      |          ^~~~~~~~~~~~~~~~~
      |          |
      |          SmallVector<[...],4>
16.232 [2804/63/1066] Building CXX object lib/DWP/CMakeFiles/LLVMDWP.dir/DWP.cpp.o
16.232 [2804/62/1067] Building CXX object lib/DWP/CMakeFiles/LLVMDWP.dir/DWPError.cpp.o
16.233 [2804/61/1068] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/CompactUnwindSupport.cpp.o
16.233 [2804/60/1069] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/DWARFRecordSectionSplitter.cpp.o
16.234 [2804/59/1070] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/EHFrameSupport.cpp.o
16.234 [2804/58/1071] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/JITLink.cpp.o
16.235 [2804/57/1072] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/JITLinkGeneric.cpp.o
16.235 [2804/56/1073] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/JITLinkMemoryManager.cpp.o
16.235 [2804/55/1074] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/MachO.cpp.o
16.236 [2804/54/1075] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/MachO_arm64.cpp.o
16.236 [2804/53/1076] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/MachO_x86_64.cpp.o
16.237 [2804/52/1077] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/MachOLinkGraphBuilder.cpp.o
16.237 [2804/51/1078] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/ELF.cpp.o
16.238 [2804/50/1079] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/ELFLinkGraphBuilder.cpp.o
16.238 [2804/49/1080] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/ELF_aarch32.cpp.o
16.239 [2804/48/1081] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/ELF_aarch64.cpp.o
16.239 [2804/47/1082] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/ELF_loongarch.cpp.o
16.240 [2804/46/1083] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/ELF_ppc64.cpp.o
16.240 [2804/45/1084] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/ELF_riscv.cpp.o
16.241 [2804/44/1085] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/ELF_x86.cpp.o
16.242 [2804/43/1086] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/ELF_x86_64.cpp.o
16.242 [2804/42/1087] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/COFF.cpp.o
16.242 [2804/41/1088] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/COFFDirectiveParser.cpp.o
16.243 [2804/40/1089] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/COFFLinkGraphBuilder.cpp.o
16.259 [2804/39/1090] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/COFF_x86_64.cpp.o
16.260 [2804/38/1091] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/XCOFF.cpp.o
16.260 [2804/37/1092] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/XCOFF_ppc64.cpp.o
16.261 [2804/36/1093] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/XCOFFLinkGraphBuilder.cpp.o
16.261 [2804/35/1094] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/aarch32.cpp.o
16.262 [2804/34/1095] Building CXX object lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/aarch64.cpp.o
16.263 [2804/33/1096] Building CXX object lib/DebugInfo/LogicalView/CMakeFiles/LLVMDebugInfoLogicalView.dir/Core/LVLine.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/153735