[llvm] [NFC][PGO] Factor downscaling of branch weights out of `Instrumentation` into `ProfileData` (PR #153735)

Thu Aug 14 22:48:04 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-9-cmake-build-only` running on `rocm-docker-rhel-9` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/18710

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[1566/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineSink.cpp.o
[1567/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineSSAContext.cpp.o
[1568/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineUniformityAnalysis.cpp.o
[1569/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineTraceMetrics.cpp.o
[1570/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRFSDiscriminator.cpp.o
[1571/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRYamlMapping.cpp.o
[1572/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineVerifier.cpp.o
[1573/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRSampleProfile.cpp.o
[1574/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MLRegAllocEvictAdvisor.cpp.o
[1575/8006] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o
FAILED: lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib/IR -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/IR -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o -MF lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o.d -o lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o -c /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/IR/ProfDataUtils.cpp
/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/IR/ProfDataUtils.cpp: In function ‘llvm::SmallVector<unsigned int> llvm::downscaleWeights(llvm::ArrayRef<long unsigned int>, std::optional<long unsigned int>)’:
/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/IR/ProfDataUtils.cpp:282:10: error: could not convert ‘DownscaledWeights’ from ‘SmallVector<[...],4>’ to ‘SmallVector<[...],12>’
  282 |   return DownscaledWeights;
      |          ^~~~~~~~~~~~~~~~~
      |          |
      |          SmallVector<[...],4>
[1576/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MultiHazardRecognizer.cpp.o
[1577/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ModuloSchedule.cpp.o
[1578/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MLRegAllocPriorityAdvisor.cpp.o
[1579/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MBFIWrapper.cpp.o
[1580/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PatchableFunction.cpp.o
[1581/8006] Building X86GenFastISel.inc...
[1582/8006] Building X86GenGlobalISel.inc...
[1583/8006] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Function.cpp.o
[1584/8006] Building X86GenDAGISel.inc...
[1585/8006] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Instruction.cpp.o
[1586/8006] Building X86GenInstrInfo.inc...
[1587/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCFGPrinter.cpp.o
[1588/8006] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopPredication.cpp.o
[1589/8006] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Instructions.cpp.o
[1590/8006] Building AMDGPUGenMCPseudoLowering.inc...
[1591/8006] Building AMDGPUGenPreLegalizeGICombiner.inc...
[1592/8006] Building AMDGPUGenPostLegalizeGICombiner.inc...
[1593/8006] Building AMDGPUGenDisassemblerTables.inc...
[1594/8006] Building AMDGPUGenSearchableTables.inc...
[1595/8006] Building AMDGPUGenCallingConv.inc...
[1596/8006] Building AMDGPUGenSubtargetInfo.inc...
[1597/8006] Building AMDGPUGenRegBankGICombiner.inc...
[1598/8006] Building AMDGPUGenMCCodeEmitter.inc...
[1599/8006] Building AMDGPUGenAsmWriter.inc...
[1600/8006] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Verifier.cpp.o
[1601/8006] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Metadata.cpp.o
[1602/8006] Building AMDGPUGenGlobalISel.inc...
[1603/8006] Building AMDGPUGenDAGISel.inc...
[1604/8006] Building AMDGPUGenInstrInfo.inc...
[1605/8006] Building AMDGPUGenAsmMatcher.inc...
[1606/8006] Building AMDGPUGenRegisterInfo.inc...
Step 7 (build cmake config) failure: build cmake config (failure)
...
[1566/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineSink.cpp.o
[1567/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineSSAContext.cpp.o
[1568/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineUniformityAnalysis.cpp.o
[1569/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineTraceMetrics.cpp.o
[1570/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRFSDiscriminator.cpp.o
[1571/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRYamlMapping.cpp.o
[1572/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineVerifier.cpp.o
[1573/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRSampleProfile.cpp.o
[1574/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MLRegAllocEvictAdvisor.cpp.o
[1575/8006] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o
FAILED: lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib/IR -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/IR -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o -MF lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o.d -o lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o -c /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/IR/ProfDataUtils.cpp
/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/IR/ProfDataUtils.cpp: In function ‘llvm::SmallVector<unsigned int> llvm::downscaleWeights(llvm::ArrayRef<long unsigned int>, std::optional<long unsigned int>)’:
/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/IR/ProfDataUtils.cpp:282:10: error: could not convert ‘DownscaledWeights’ from ‘SmallVector<[...],4>’ to ‘SmallVector<[...],12>’
  282 |   return DownscaledWeights;
      |          ^~~~~~~~~~~~~~~~~
      |          |
      |          SmallVector<[...],4>
[1576/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MultiHazardRecognizer.cpp.o
[1577/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ModuloSchedule.cpp.o
[1578/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MLRegAllocPriorityAdvisor.cpp.o
[1579/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MBFIWrapper.cpp.o
[1580/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PatchableFunction.cpp.o
[1581/8006] Building X86GenFastISel.inc...
[1582/8006] Building X86GenGlobalISel.inc...
[1583/8006] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Function.cpp.o
[1584/8006] Building X86GenDAGISel.inc...
[1585/8006] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Instruction.cpp.o
[1586/8006] Building X86GenInstrInfo.inc...
[1587/8006] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCFGPrinter.cpp.o
[1588/8006] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopPredication.cpp.o
[1589/8006] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Instructions.cpp.o
[1590/8006] Building AMDGPUGenMCPseudoLowering.inc...
[1591/8006] Building AMDGPUGenPreLegalizeGICombiner.inc...
[1592/8006] Building AMDGPUGenPostLegalizeGICombiner.inc...
[1593/8006] Building AMDGPUGenDisassemblerTables.inc...
[1594/8006] Building AMDGPUGenSearchableTables.inc...
[1595/8006] Building AMDGPUGenCallingConv.inc...
[1596/8006] Building AMDGPUGenSubtargetInfo.inc...
[1597/8006] Building AMDGPUGenRegBankGICombiner.inc...
[1598/8006] Building AMDGPUGenMCCodeEmitter.inc...
[1599/8006] Building AMDGPUGenAsmWriter.inc...
[1600/8006] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Verifier.cpp.o
[1601/8006] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Metadata.cpp.o
[1602/8006] Building AMDGPUGenGlobalISel.inc...
[1603/8006] Building AMDGPUGenDAGISel.inc...
[1604/8006] Building AMDGPUGenInstrInfo.inc...
[1605/8006] Building AMDGPUGenAsmMatcher.inc...
[1606/8006] Building AMDGPUGenRegisterInfo.inc...

```

</details>

https://github.com/llvm/llvm-project/pull/153735