[llvm] [DWARFLinker] Fix matching logic to remove type 1 missing offsets (PR #149618)

Thu Jul 31 01:45:20 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-debian` running on `gribozavr4` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/builds/23565

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
90.261 [2930/96/1159] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/CanonicalizeFreezeInLoops.cpp.o
90.665 [2929/96/1160] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/IntegerDivision.cpp.o
90.689 [2928/96/1161] Building CXX object lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/LegalizeVectorTypes.cpp.o
90.719 [2927/96/1162] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/SymbolRewriter.cpp.o
90.873 [2926/96/1163] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/EntryExitInstrumenter.cpp.o
90.887 [2925/96/1164] Building CXX object lib/DWARFLinker/Parallel/CMakeFiles/LLVMDWARFLinkerParallel.dir/SyntheticTypeNameBuilder.cpp.o
90.908 [2924/96/1165] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/Utils.cpp.o
91.065 [2923/96/1166] Building CXX object lib/DWARFLinker/Parallel/CMakeFiles/LLVMDWARFLinkerParallel.dir/DIEAttributeCloner.cpp.o
91.106 [2922/96/1167] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/FunctionComparator.cpp.o
91.235 [2921/96/1168] Building CXX object lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o
FAILED: lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/clang++ -DEXPENSIVE_CHECKS -DEXPERIMENTAL_KEY_INSTRUCTIONS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__SHORT_FILE__=\"DWARFLinker.cpp\" -I/b/1/llvm-clang-x86_64-expensive-checks-debian/build/lib/DWARFLinker/Classic -I/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/lib/DWARFLinker/Classic -I/b/1/llvm-clang-x86_64-expensive-checks-debian/build/include -I/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/include -U_GLIBCXX_DEBUG -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o -MF lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o.d -o lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o -c /b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp
/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:479:37: error: 'NextSeqOff' in capture list does not name a variable
    auto StmtAttrSmallerThanNext = [NextSeqOff](const PatchLocation &SA) {
                                    ^
/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:480:25: error: reference to local binding 'NextSeqOff' declared in enclosing function 'llvm::constructSeqOffsettoOrigRowMapping'
      return SA.get() < NextSeqOff;
                        ^
/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:478:14: note: 'NextSeqOff' declared here
  for (auto [NextSeqOff, NextRow] : LineTableMapping) {
             ^
/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:482:37: error: 'NextRow' in capture list does not name a variable
    auto SeqStartSmallerThanNext = [NextRow](const size_t &Row) {
                                    ^
/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:483:20: error: reference to local binding 'NextRow' declared in enclosing function 'llvm::constructSeqOffsettoOrigRowMapping'
      return Row < NextRow;
                   ^
/b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:478:26: note: 'NextRow' declared here
  for (auto [NextSeqOff, NextRow] : LineTableMapping) {
                         ^
4 errors generated.
91.537 [2921/95/1169] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/CallPromotionUtils.cpp.o
91.548 [2921/94/1170] Building CXX object lib/DWARFLinker/Parallel/CMakeFiles/LLVMDWARFLinkerParallel.dir/DWARFLinker.cpp.o
91.619 [2921/93/1171] Building CXX object lib/DWARFLinker/Parallel/CMakeFiles/LLVMDWARFLinkerParallel.dir/OutputSections.cpp.o
91.794 [2921/92/1172] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LowerAtomic.cpp.o
91.844 [2921/91/1173] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/FixIrreducible.cpp.o
92.146 [2921/90/1174] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/BreakCriticalEdges.cpp.o
92.315 [2921/89/1175] Building CXX object lib/CodeGen/GlobalISel/CMakeFiles/LLVMGlobalISel.dir/Legalizer.cpp.o
92.395 [2921/88/1176] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/Instrumentation.cpp.o
92.438 [2921/87/1177] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/BuildLibCalls.cpp.o
92.545 [2921/86/1178] Building CXX object lib/Frontend/Offloading/CMakeFiles/LLVMFrontendOffloading.dir/Utility.cpp.o
93.002 [2921/85/1179] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LowerInvoke.cpp.o
93.072 [2921/84/1180] Building CXX object lib/CodeGen/GlobalISel/CMakeFiles/LLVMGlobalISel.dir/MachineIRBuilder.cpp.o
93.488 [2921/83/1181] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/GuardUtils.cpp.o
93.532 [2921/82/1182] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LowerVectorIntrinsics.cpp.o
93.828 [2921/81/1183] Building CXX object lib/CodeGen/GlobalISel/CMakeFiles/LLVMGlobalISel.dir/Utils.cpp.o
93.923 [2921/80/1184] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/InjectTLIMappings.cpp.o
93.982 [2921/79/1185] Building CXX object lib/CodeGen/MIRParser/CMakeFiles/LLVMMIRParser.dir/MIParser.cpp.o
94.241 [2921/78/1186] Building CXX object lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFStreamer.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/149618