[llvm] [DWARFLinker] Fix matching logic to remove type 1 missing offsets (PR #149618)

Thu Jul 31 01:45:31 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/34276

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
101.001 [5893/96/1524] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/Instrumentation.cpp.o
101.211 [5892/96/1525] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/EntryExitInstrumenter.cpp.o
101.277 [5891/96/1526] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/FunctionComparator.cpp.o
101.309 [5890/96/1527] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/BlockCoverageInference.cpp.o
101.318 [5889/96/1528] Building CXX object lib/CodeGen/GlobalISel/CMakeFiles/LLVMGlobalISel.dir/InstructionSelect.cpp.o
101.353 [5888/96/1529] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/InjectTLIMappings.cpp.o
101.434 [5887/96/1530] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/FixIrreducible.cpp.o
101.578 [5886/96/1531] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/CallPromotionUtils.cpp.o
101.592 [5885/96/1532] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/BreakCriticalEdges.cpp.o
101.754 [5884/96/1533] Building CXX object lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o
FAILED: lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/clang++ -DEXPERIMENTAL_KEY_INSTRUCTIONS -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__SHORT_FILE__=\"DWARFLinker.cpp\" -I/b/1/llvm-x86_64-debian-dylib/build/lib/DWARFLinker/Classic -I/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/lib/DWARFLinker/Classic -I/b/1/llvm-x86_64-debian-dylib/build/include -I/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o -MF lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o.d -o lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o -c /b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:479:37: error: 'NextSeqOff' in capture list does not name a variable
    auto StmtAttrSmallerThanNext = [NextSeqOff](const PatchLocation &SA) {
                                    ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:480:25: error: reference to local binding 'NextSeqOff' declared in enclosing function 'llvm::constructSeqOffsettoOrigRowMapping'
      return SA.get() < NextSeqOff;
                        ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:478:14: note: 'NextSeqOff' declared here
  for (auto [NextSeqOff, NextRow] : LineTableMapping) {
             ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:482:37: error: 'NextRow' in capture list does not name a variable
    auto SeqStartSmallerThanNext = [NextRow](const size_t &Row) {
                                    ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:483:20: error: reference to local binding 'NextRow' declared in enclosing function 'llvm::constructSeqOffsettoOrigRowMapping'
      return Row < NextRow;
                   ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:478:26: note: 'NextRow' declared here
  for (auto [NextSeqOff, NextRow] : LineTableMapping) {
                         ^
4 errors generated.
101.814 [5884/95/1534] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LowerVectorIntrinsics.cpp.o
102.087 [5884/94/1535] Building CXX object lib/Frontend/Offloading/CMakeFiles/LLVMFrontendOffloading.dir/Utility.cpp.o
102.087 [5884/93/1536] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/IRNormalizer.cpp.o
102.118 [5884/92/1537] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/GuardUtils.cpp.o
102.344 [5884/91/1538] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LowerInvoke.cpp.o
102.421 [5884/90/1539] Building CXX object lib/DWARFLinker/Parallel/CMakeFiles/LLVMDWARFLinkerParallel.dir/DWARFLinker.cpp.o
102.526 [5884/89/1540] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LowerAtomic.cpp.o
102.695 [5884/88/1541] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/Evaluator.cpp.o
102.748 [5884/87/1542] Building CXX object lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFStreamer.cpp.o
102.859 [5884/86/1543] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/AssumeBundleBuilder.cpp.o
103.036 [5884/85/1544] Building CXX object lib/Bitcode/Reader/CMakeFiles/LLVMBitReader.dir/MetadataLoader.cpp.o
103.311 [5884/84/1545] Building CXX object lib/DWARFLinker/Parallel/CMakeFiles/LLVMDWARFLinkerParallel.dir/DWARFEmitterImpl.cpp.o
103.444 [5884/83/1546] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/MisExpect.cpp.o
103.497 [5884/82/1547] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LowerGlobalDtors.cpp.o
103.613 [5884/81/1548] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/Mem2Reg.cpp.o
103.642 [5884/80/1549] Building CXX object lib/CodeGen/MIRParser/CMakeFiles/LLVMMIRParser.dir/MIRParser.cpp.o
103.647 [5884/79/1550] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LibCallsShrinkWrap.cpp.o
103.759 [5884/78/1551] Building CXX object lib/DWARFLinker/Parallel/CMakeFiles/LLVMDWARFLinkerParallel.dir/DWARFLinkerUnit.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/149618