[llvm] [DWARFLinker] Fix matching logic to remove type 1 missing offsets (PR #149618)

Thu Jul 31 01:42:22 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast` running on `gribozavr4` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/32150

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
59.756 [4591/96/1645] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/SymbolRewriter.cpp.o
59.829 [4590/96/1646] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/FunctionComparator.cpp.o
59.954 [4589/96/1647] Building CXX object lib/DWARFLinker/Parallel/CMakeFiles/LLVMDWARFLinkerParallel.dir/DependencyTracker.cpp.o
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Parallel/DependencyTracker.cpp:9:
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Parallel/DependencyTracker.h:12:
/b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Parallel/DWARFLinkerCompileUnit.h:344:8: warning: '\returns' command used in a comment that is attached to a function returning void [-Wdocumentation]
  /// \returns DieInfo descriptor.
      ~^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
59.968 [4588/96/1648] Building CXX object lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o
FAILED: lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/clang++ -DEXPERIMENTAL_KEY_INSTRUCTIONS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__SHORT_FILE__=\"DWARFLinker.cpp\" -I/b/1/clang-x86_64-debian-fast/llvm.obj/lib/DWARFLinker/Classic -I/b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Classic -I/b/1/clang-x86_64-debian-fast/llvm.obj/include -I/b/1/clang-x86_64-debian-fast/llvm.src/llvm/include -std=c++11 -Wdocumentation -Wno-documentation-deprecated-sync -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o -MF lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o.d -o lib/DWARFLinker/Classic/CMakeFiles/LLVMDWARFLinkerClassic.dir/DWARFLinker.cpp.o -c /b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp
/b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:301:6: warning: '\return' command used in a comment that is attached to a function returning void [-Wdocumentation]
/// \return true when this DIE and all of its children are only
    ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:479:37: error: 'NextSeqOff' in capture list does not name a variable
    auto StmtAttrSmallerThanNext = [NextSeqOff](const PatchLocation &SA) {
                                    ^
/b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:480:25: error: reference to local binding 'NextSeqOff' declared in enclosing function 'llvm::constructSeqOffsettoOrigRowMapping'
      return SA.get() < NextSeqOff;
                        ^
/b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:478:14: note: 'NextSeqOff' declared here
  for (auto [NextSeqOff, NextRow] : LineTableMapping) {
             ^
/b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:482:37: error: 'NextRow' in capture list does not name a variable
    auto SeqStartSmallerThanNext = [NextRow](const size_t &Row) {
                                    ^
/b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:483:20: error: reference to local binding 'NextRow' declared in enclosing function 'llvm::constructSeqOffsettoOrigRowMapping'
      return Row < NextRow;
                   ^
/b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp:478:26: note: 'NextRow' declared here
  for (auto [NextSeqOff, NextRow] : LineTableMapping) {
                         ^
1 warning and 4 errors generated.
59.968 [4588/95/1649] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/Utils.cpp.o
60.017 [4588/94/1650] Building CXX object lib/Bitcode/Writer/CMakeFiles/LLVMBitWriter.dir/ValueEnumerator.cpp.o
60.301 [4588/93/1651] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/FixIrreducible.cpp.o
60.460 [4588/92/1652] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/BuildLibCalls.cpp.o
60.521 [4588/91/1653] Building CXX object lib/DWARFLinker/Parallel/CMakeFiles/LLVMDWARFLinkerParallel.dir/OutputSections.cpp.o
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Parallel/OutputSections.cpp:10:
/b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/DWARFLinker/Parallel/DWARFLinkerCompileUnit.h:344:8: warning: '\returns' command used in a comment that is attached to a function returning void [-Wdocumentation]
  /// \returns DieInfo descriptor.
      ~^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
60.570 [4588/90/1654] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LowerAtomic.cpp.o
60.604 [4588/89/1655] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/Evaluator.cpp.o
60.693 [4588/88/1656] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/Instrumentation.cpp.o
60.746 [4588/87/1657] Building CXX object lib/CodeGen/GlobalISel/CMakeFiles/LLVMGlobalISel.dir/MachineIRBuilder.cpp.o
In file included from /b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/CodeGen/GlobalISel/MachineIRBuilder.cpp:11:

```

</details>

https://github.com/llvm/llvm-project/pull/149618