[llvm] [BOLT] Gadget scanner: factor out utility code (PR #131895)

Kristof Beyls via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 20 02:14:14 PDT 2025


https://github.com/kbeyls commented:

Thank you, this is a very nice cleanup!

Apart from my other minor comments, I'm wondering if it would be useful to have 1 regression test that checks debug output....
I think we typically don't do that in LLVM, but when we're doing a mostly NFC change of how debug printing works, ideally, there should be a test to show that we're not changing it (or only changing it in the way we intended)?
I wonder if you have an opinion about adding a small regression test to document/test what the "trace" output is expected to look like?

https://github.com/llvm/llvm-project/pull/131895


More information about the llvm-commits mailing list