[llvm] 1873f55 - [MIRVRegNamerUtils] Use Register. NFC

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 6 22:55:58 PST 2025


Author: Craig Topper
Date: 2025-03-06T22:51:05-08:00
New Revision: 1873f5567ad460995fb3f3cdd51058a03a8044e2

URL: https://github.com/llvm/llvm-project/commit/1873f5567ad460995fb3f3cdd51058a03a8044e2
DIFF: https://github.com/llvm/llvm-project/commit/1873f5567ad460995fb3f3cdd51058a03a8044e2.diff

LOG: [MIRVRegNamerUtils] Use Register. NFC

Added: 
    

Modified: 
    llvm/lib/CodeGen/MIRVRegNamerUtils.cpp
    llvm/lib/CodeGen/MIRVRegNamerUtils.h

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/MIRVRegNamerUtils.cpp b/llvm/lib/CodeGen/MIRVRegNamerUtils.cpp
index 49c8a0e466337..b888b81e92b92 100644
--- a/llvm/lib/CodeGen/MIRVRegNamerUtils.cpp
+++ b/llvm/lib/CodeGen/MIRVRegNamerUtils.cpp
@@ -20,7 +20,7 @@ static cl::opt<bool>
                        cl::Hidden,
                        cl::desc("Use Stable Hashing for MIR VReg Renaming"));
 
-using VRegRenameMap = std::map<unsigned, unsigned>;
+using VRegRenameMap = std::map<Register, Register>;
 
 bool VRegRenamer::doVRegRenaming(const VRegRenameMap &VRM) {
   bool Changed = false;
@@ -45,7 +45,7 @@ VRegRenamer::getVRegRenameMap(const std::vector<NamedVReg> &VRegs) {
 
   VRegRenameMap VRM;
   for (const auto &VReg : VRegs) {
-    const unsigned Reg = VReg.getReg();
+    const Register Reg = VReg.getReg();
     VRM[Reg] = createVirtualRegisterWithLowerName(Reg, GetUniqueVRegName(VReg));
   }
   return VRM;
@@ -77,7 +77,7 @@ std::string VRegRenamer::getInstructionOpcodeHash(MachineInstr &MI) {
     case MachineOperand::MO_Register:
       if (MO.getReg().isVirtual())
         return MRI.getVRegDef(MO.getReg())->getOpcode();
-      return MO.getReg();
+      return MO.getReg().id();
     case MachineOperand::MO_Immediate:
       return MO.getImm();
     case MachineOperand::MO_TargetIndex:
@@ -136,8 +136,8 @@ std::string VRegRenamer::getInstructionOpcodeHash(MachineInstr &MI) {
   return OS.str();
 }
 
-unsigned VRegRenamer::createVirtualRegister(unsigned VReg) {
-  assert(Register::isVirtualRegister(VReg) && "Expected Virtual Registers");
+Register VRegRenamer::createVirtualRegister(Register VReg) {
+  assert(VReg.isVirtual() && "Expected Virtual Registers");
   std::string Name = getInstructionOpcodeHash(*MRI.getVRegDef(VReg));
   return createVirtualRegisterWithLowerName(VReg, Name);
 }
@@ -160,10 +160,10 @@ bool VRegRenamer::renameInstsInMBB(MachineBasicBlock *MBB) {
         NamedVReg(MO.getReg(), Prefix + getInstructionOpcodeHash(Candidate)));
   }
 
-  return VRegs.size() ? doVRegRenaming(getVRegRenameMap(VRegs)) : false;
+  return !VRegs.empty() ? doVRegRenaming(getVRegRenameMap(VRegs)) : false;
 }
 
-unsigned VRegRenamer::createVirtualRegisterWithLowerName(unsigned VReg,
+Register VRegRenamer::createVirtualRegisterWithLowerName(Register VReg,
                                                          StringRef Name) {
   std::string LowerName = Name.lower();
   const TargetRegisterClass *RC = MRI.getRegClassOrNull(VReg);

diff  --git a/llvm/lib/CodeGen/MIRVRegNamerUtils.h b/llvm/lib/CodeGen/MIRVRegNamerUtils.h
index a059bc5333c65..055bb9576c048 100644
--- a/llvm/lib/CodeGen/MIRVRegNamerUtils.h
+++ b/llvm/lib/CodeGen/MIRVRegNamerUtils.h
@@ -61,19 +61,19 @@ class VRegRenamer {
 
   /// For all the VRegs that are candidates for renaming,
   /// return a mapping from old vregs to new vregs with names.
-  std::map<unsigned, unsigned>
+  std::map<Register, Register>
   getVRegRenameMap(const std::vector<NamedVReg> &VRegs);
 
   /// Perform replacing of registers based on the <old,new> vreg map.
-  bool doVRegRenaming(const std::map<unsigned, unsigned> &VRegRenameMap);
+  bool doVRegRenaming(const std::map<Register, Register> &VRegRenameMap);
 
   /// createVirtualRegister - Given an existing vreg, create a named vreg to
   /// take its place. The name is determined by calling
   /// getInstructionOpcodeHash.
-  unsigned createVirtualRegister(unsigned VReg);
+  Register createVirtualRegister(Register VReg);
 
   /// Create a vreg with name and return it.
-  unsigned createVirtualRegisterWithLowerName(unsigned VReg, StringRef Name);
+  Register createVirtualRegisterWithLowerName(Register VReg, StringRef Name);
 
   /// Linearly traverse the MachineBasicBlock and rename each instruction's
   /// vreg definition based on the semantics of the instruction.


        


More information about the llvm-commits mailing list