[llvm] 8dd6095 - Support: Do not check if a file exists before executing (#128821)

[via llvm-commits]

Author: Matt Arsenault
Date: 2025-02-26T13:51:40+07:00
New Revision: 8dd609598e498faa34c7bdb777718d6c6622fa27

URL: https://github.com/llvm/llvm-project/commit/8dd609598e498faa34c7bdb777718d6c6622fa27
DIFF: https://github.com/llvm/llvm-project/commit/8dd609598e498faa34c7bdb777718d6c6622fa27.diff

LOG: Support: Do not check if a file exists before executing (#128821)

Let the actual syscall error if the file doesn't exist. This produces
a more standard "no such file or directory" phrasing of the error
message,
and avoids an extra step.

The same antipattern appears in the windows code, we should probably
fix that one too.

Added: 
    

Modified: 
    llvm/lib/Support/Unix/Program.inc
    llvm/test/tools/llvm-rc/windres-preproc.test

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Support/Unix/Program.inc b/llvm/lib/Support/Unix/Program.inc
index 0708df1eed0a3..6d68369ad191c 100644
--- a/llvm/lib/Support/Unix/Program.inc
+++ b/llvm/lib/Support/Unix/Program.inc
@@ -168,13 +168,6 @@ static bool Execute(ProcessInfo &PI, StringRef Program,
                     ArrayRef<std::optional<StringRef>> Redirects,
                     unsigned MemoryLimit, std::string *ErrMsg,
                     BitVector *AffinityMask, bool DetachProcess) {
-  if (!llvm::sys::fs::exists(Program)) {
-    if (ErrMsg)
-      *ErrMsg = std::string("Executable \"") + Program.str() +
-                std::string("\" doesn't exist!");
-    return false;
-  }
-
   assert(!AffinityMask && "Starting a process with an affinity mask is "
                           "currently not supported on Unix!");
 

diff  --git a/llvm/test/tools/llvm-rc/windres-preproc.test b/llvm/test/tools/llvm-rc/windres-preproc.test
index 52427862e760b..df0a674ef0132 100644
--- a/llvm/test/tools/llvm-rc/windres-preproc.test
+++ b/llvm/test/tools/llvm-rc/windres-preproc.test
@@ -19,8 +19,8 @@
 
 ;; Test error messages when unable to execute the preprocessor.
 
-; RUN: not llvm-windres --preprocessor intentionally-missing-executable %p/Inputs/empty.rc %t.res 2>&1 | FileCheck %s --check-prefix=CHECK4
-; CHECK4: llvm-rc: Preprocessing failed: Executable "intentionally-missing-executable" doesn't exist!
+; RUN: not llvm-windres --preprocessor intentionally-missing-executable %p/Inputs/empty.rc %t.res 2>&1 | FileCheck -DMSG=%errc_ENOENT %s --check-prefix=CHECK4
+; CHECK4: llvm-rc: Preprocessing failed: posix_spawn failed: [[MSG]]
 
 ;; Test --preprocessor with an argument with spaces.