[llvm] [ConstraintElim] Teach checkAndReplaceCondition about samesign (PR #128168)

[Marina Taylor via llvm-commits]

https://github.com/citymarina updated https://github.com/llvm/llvm-project/pull/128168

>From fb802ede3e9008d8efbde658a056008a47e450dc Mon Sep 17 00:00:00 2001
From: Marina Taylor <marina_taylor at apple.com>
Date: Fri, 21 Feb 2025 17:35:54 +0000
Subject: [PATCH 1/2] [ConstraintElim] Add samesign test. NFC

---
 .../transfer-samesign-facts.ll                | 63 +++++++++++++++++++
 1 file changed, 63 insertions(+)

diff --git a/llvm/test/Transforms/ConstraintElimination/transfer-samesign-facts.ll b/llvm/test/Transforms/ConstraintElimination/transfer-samesign-facts.ll
index 1b155e050de29..3597ff9515353 100644
--- a/llvm/test/Transforms/ConstraintElimination/transfer-samesign-facts.ll
+++ b/llvm/test/Transforms/ConstraintElimination/transfer-samesign-facts.ll
@@ -303,3 +303,66 @@ define i1 @ugt_assumed_positive_values(i8 %a, i8 %b) {
 
   ret i1 %result
 }
+
+define i1 @implied_condition_sgt_ugt(i8 %a, i8 %b)  {
+; CHECK-LABEL: @implied_condition_sgt_ugt(
+; CHECK-NEXT:    [[CMP_SGT:%.*]] = icmp sgt i8 [[A:%.*]], [[B:%.*]]
+; CHECK-NEXT:    br i1 [[CMP_SGT]], label [[GREATER:%.*]], label [[EXIT:%.*]]
+; CHECK:       greater:
+; CHECK-NEXT:    [[CMP_UGT:%.*]] = icmp samesign ugt i8 [[A]], [[B]]
+; CHECK-NEXT:    ret i1 [[CMP_UGT]]
+; CHECK:       exit:
+; CHECK-NEXT:    ret i1 false
+;
+  %cmp_sgt = icmp sgt i8 %a, %b
+  br i1 %cmp_sgt, label %greater, label %exit
+
+greater:
+  %cmp_ugt = icmp samesign ugt i8 %a, %b
+  ret i1 %cmp_ugt
+
+exit:
+  ret i1 false
+}
+
+define i1 @implied_condition_sle_ule(i8 %a) {
+; CHECK-LABEL: @implied_condition_sle_ule(
+; CHECK-NEXT:    [[CMP_SLE:%.*]] = icmp sle i8 [[A:%.*]], 42
+; CHECK-NEXT:    br i1 [[CMP_SLE]], label [[LESS_OR_EQUAL:%.*]], label [[EXIT:%.*]]
+; CHECK:       less_or_equal:
+; CHECK-NEXT:    [[CMP_ULE:%.*]] = icmp samesign ule i8 [[A]], 42
+; CHECK-NEXT:    ret i1 [[CMP_ULE]]
+; CHECK:       exit:
+; CHECK-NEXT:    ret i1 false
+;
+  %cmp_sle = icmp sle i8 %a, 42
+  br i1 %cmp_sle, label %less_or_equal, label %exit
+
+less_or_equal:
+  %cmp_ule = icmp samesign ule i8 %a, 42
+  ret i1 %cmp_ule
+
+exit:
+  ret i1 false
+}
+
+define i1 @implied_condition_cannot_simplify(i8 %a, i8 %b) {
+; CHECK-LABEL: @implied_condition_cannot_simplify(
+; CHECK-NEXT:    [[CMP_SGT:%.*]] = icmp ne i8 [[A:%.*]], [[B:%.*]]
+; CHECK-NEXT:    br i1 [[CMP_SGT]], label [[GREATER:%.*]], label [[EXIT:%.*]]
+; CHECK:       not_equal:
+; CHECK-NEXT:    [[CMP_UGT:%.*]] = icmp samesign ugt i8 [[A]], [[B]]
+; CHECK-NEXT:    ret i1 [[CMP_UGT]]
+; CHECK:       exit:
+; CHECK-NEXT:    ret i1 false
+;
+  %cmp_ne = icmp ne i8 %a, %b
+  br i1 %cmp_ne, label %not_equal, label %exit
+
+not_equal:
+  %cmp_ugt = icmp samesign ugt i8 %a, %b
+  ret i1 %cmp_ugt
+
+exit:
+  ret i1 false
+}

>From dbe26daae980dab9dd579e5d3ee7d3cffb1932e1 Mon Sep 17 00:00:00 2001
From: Marina Taylor <marina_taylor at apple.com>
Date: Mon, 24 Feb 2025 11:59:51 +0000
Subject: [PATCH 2/2] [ConstraintElim] Teach checkAndReplaceCondition about
 samesign

---
 llvm/lib/Transforms/Scalar/ConstraintElimination.cpp  | 11 ++++++++++-
 .../ConstraintElimination/transfer-samesign-facts.ll  |  6 ++----
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp b/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
index 6dd26910f6846..79f6858463d7e 100644
--- a/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
+++ b/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
@@ -1427,7 +1427,7 @@ static std::optional<bool> checkCondition(CmpInst::Predicate Pred, Value *A,
 }
 
 static bool checkAndReplaceCondition(
-    CmpInst *Cmp, ConstraintInfo &Info, unsigned NumIn, unsigned NumOut,
+    ICmpInst *Cmp, ConstraintInfo &Info, unsigned NumIn, unsigned NumOut,
     Instruction *ContextInst, Module *ReproducerModule,
     ArrayRef<ReproducerEntry> ReproducerCondStack, DominatorTree &DT,
     SmallVectorImpl<Instruction *> &ToRemove) {
@@ -1460,6 +1460,15 @@ static bool checkAndReplaceCondition(
           checkCondition(Cmp->getPredicate(), Cmp->getOperand(0),
                          Cmp->getOperand(1), Cmp, Info))
     return ReplaceCmpWithConstant(Cmp, *ImpliedCondition);
+
+  // When the predicate is samesign and unsigned, we can also make use of the
+  // signed predicate information.
+  if (Cmp->hasSameSign() && Cmp->isUnsigned())
+    if (auto ImpliedCondition =
+            checkCondition(Cmp->getSignedPredicate(), Cmp->getOperand(0),
+                           Cmp->getOperand(1), Cmp, Info))
+      return ReplaceCmpWithConstant(Cmp, *ImpliedCondition);
+
   return false;
 }
 
diff --git a/llvm/test/Transforms/ConstraintElimination/transfer-samesign-facts.ll b/llvm/test/Transforms/ConstraintElimination/transfer-samesign-facts.ll
index 3597ff9515353..44565f8d1341f 100644
--- a/llvm/test/Transforms/ConstraintElimination/transfer-samesign-facts.ll
+++ b/llvm/test/Transforms/ConstraintElimination/transfer-samesign-facts.ll
@@ -309,8 +309,7 @@ define i1 @implied_condition_sgt_ugt(i8 %a, i8 %b)  {
 ; CHECK-NEXT:    [[CMP_SGT:%.*]] = icmp sgt i8 [[A:%.*]], [[B:%.*]]
 ; CHECK-NEXT:    br i1 [[CMP_SGT]], label [[GREATER:%.*]], label [[EXIT:%.*]]
 ; CHECK:       greater:
-; CHECK-NEXT:    [[CMP_UGT:%.*]] = icmp samesign ugt i8 [[A]], [[B]]
-; CHECK-NEXT:    ret i1 [[CMP_UGT]]
+; CHECK-NEXT:    ret i1 true
 ; CHECK:       exit:
 ; CHECK-NEXT:    ret i1 false
 ;
@@ -330,8 +329,7 @@ define i1 @implied_condition_sle_ule(i8 %a) {
 ; CHECK-NEXT:    [[CMP_SLE:%.*]] = icmp sle i8 [[A:%.*]], 42
 ; CHECK-NEXT:    br i1 [[CMP_SLE]], label [[LESS_OR_EQUAL:%.*]], label [[EXIT:%.*]]
 ; CHECK:       less_or_equal:
-; CHECK-NEXT:    [[CMP_ULE:%.*]] = icmp samesign ule i8 [[A]], 42
-; CHECK-NEXT:    ret i1 [[CMP_ULE]]
+; CHECK-NEXT:    ret i1 true
 ; CHECK:       exit:
 ; CHECK-NEXT:    ret i1 false
 ;