[llvm] [BOLT][AArch64] Exclude JT pattern matching under assert failure (PR #122298)
Pavel Iliin via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 27 09:26:21 PST 2025
ilinpv wrote:
> @ilinpv definitely we should extend the number of supported patterns for jump table, but above PR #124372 is unified and exclude assert for unknown table right now. How about another idea, I will just take this test and add it to repo with checking that this patterns must generate log: "failed pattern matching ...." . We will see which templates exist and which are not currently supported. Your analyze can be based on having in front of you the patterns of jump tables which we have met in code.
Right, no question about PR #124372 necessity, and no question about generating in log fails of pattern matching. If I read the code correctly both of these things were already incorporated in your patch. My point is about benefit of extending number of supported patterns by (1) "few extra jump table patterns provided" in this PR and (2) "set of common jt patterns for different compilers (gcc, clang, golang)" you collected. Of course, it can certainly be done in a separate PRs, if that works better for you.
https://github.com/llvm/llvm-project/pull/122298
More information about the llvm-commits
mailing list