[llvm] 6e8718c - [ARC,test] Change llc -march= to -mtriple=
Fangrui Song via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 15 12:29:59 PST 2024
Author: Fangrui Song
Date: 2024-12-15T12:29:53-08:00
New Revision: 6e8718c3e32225c579a3a974be003c7f38c32a05
URL: https://github.com/llvm/llvm-project/commit/6e8718c3e32225c579a3a974be003c7f38c32a05
DIFF: https://github.com/llvm/llvm-project/commit/6e8718c3e32225c579a3a974be003c7f38c32a05.diff
LOG: [ARC,test] Change llc -march= to -mtriple=
Similar to 806761a7629df268c8aed49657aeccffa6bca449
-mtriple= specifies the full target triple while -march= merely sets the
architecture part of the default target triple (e.g. Windows, macOS),
leaving a target triple which may not make sense.
Therefore, -march= is error-prone and not recommended for tests without
a target triple. The issue has been benign as we recognize
arc-apple-darwin as ELF instead of rejecting it outrightly.
Added:
Modified:
llvm/test/CodeGen/ARC/addrmode.ll
llvm/test/CodeGen/ARC/alu.ll
llvm/test/CodeGen/ARC/brcc.ll
llvm/test/CodeGen/ARC/call.ll
llvm/test/CodeGen/ARC/intrinsics.ll
llvm/test/CodeGen/ARC/ldst.ll
Removed:
################################################################################
diff --git a/llvm/test/CodeGen/ARC/addrmode.ll b/llvm/test/CodeGen/ARC/addrmode.ll
index 248ec7d4238f1a..c23fde2e2276d6 100644
--- a/llvm/test/CodeGen/ARC/addrmode.ll
+++ b/llvm/test/CodeGen/ARC/addrmode.ll
@@ -1,4 +1,4 @@
-; RUN: llc -march=arc < %s | FileCheck %s
+; RUN: llc -mtriple=arc < %s | FileCheck %s
; CHECK-LABEL: copy
; CHECK-NOT: add
diff --git a/llvm/test/CodeGen/ARC/alu.ll b/llvm/test/CodeGen/ARC/alu.ll
index 2315196d427ce9..4092ffa5e0a59c 100644
--- a/llvm/test/CodeGen/ARC/alu.ll
+++ b/llvm/test/CodeGen/ARC/alu.ll
@@ -1,4 +1,4 @@
-; RUN: llc -march=arc < %s | FileCheck %s
+; RUN: llc -mtriple=arc < %s | FileCheck %s
; CHECK-LABEL: add_r
; CHECK: add %r0, %r{{[01]}}, %r{{[01]}}
diff --git a/llvm/test/CodeGen/ARC/brcc.ll b/llvm/test/CodeGen/ARC/brcc.ll
index 2884710d6754aa..2d12122c91bb80 100644
--- a/llvm/test/CodeGen/ARC/brcc.ll
+++ b/llvm/test/CodeGen/ARC/brcc.ll
@@ -1,4 +1,4 @@
-; RUN: llc -march=arc < %s | FileCheck %s
+; RUN: llc -mtriple=arc < %s | FileCheck %s
; CHECK-LABEL: brcc1:
; CHECK: brne %r0, %r1, @.LBB0_2
diff --git a/llvm/test/CodeGen/ARC/call.ll b/llvm/test/CodeGen/ARC/call.ll
index d74b35a35f65ef..78d18fe685ea00 100644
--- a/llvm/test/CodeGen/ARC/call.ll
+++ b/llvm/test/CodeGen/ARC/call.ll
@@ -1,4 +1,4 @@
-; RUN: llc -march=arc < %s | FileCheck %s
+; RUN: llc -mtriple=arc < %s | FileCheck %s
declare i32 @goo1(i32) nounwind
diff --git a/llvm/test/CodeGen/ARC/intrinsics.ll b/llvm/test/CodeGen/ARC/intrinsics.ll
index 873a911281c4aa..b1e799a9c5d86b 100644
--- a/llvm/test/CodeGen/ARC/intrinsics.ll
+++ b/llvm/test/CodeGen/ARC/intrinsics.ll
@@ -1,4 +1,4 @@
-; RUN: llc -march=arc < %s | FileCheck %s
+; RUN: llc -mtriple=arc < %s | FileCheck %s
target triple = "arc"
diff --git a/llvm/test/CodeGen/ARC/ldst.ll b/llvm/test/CodeGen/ARC/ldst.ll
index 99b43de71cb4d5..2d530b7232285b 100644
--- a/llvm/test/CodeGen/ARC/ldst.ll
+++ b/llvm/test/CodeGen/ARC/ldst.ll
@@ -1,4 +1,4 @@
-; RUN: llc -march=arc < %s | FileCheck %s
+; RUN: llc -mtriple=arc < %s | FileCheck %s
; CHECK-LABEL: load32
; CHECK: ld %r0, [%r0,16000]
More information about the llvm-commits
mailing list