[lld] [LLD][COFF] Store reference to SymbolTable instead of COFFLinkerContext in InputFile (NFC) (PR #119296)
Martin Storsjö via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 13 13:59:32 PST 2024
================
@@ -403,8 +404,8 @@ class BitcodeFile : public InputFile {
// .dll file. MinGW only.
class DLLFile : public InputFile {
public:
- explicit DLLFile(COFFLinkerContext &ctx, MemoryBufferRef m)
- : InputFile(ctx, DLLKind, m) {}
+ explicit DLLFile(SymbolTable &symtab, MemoryBufferRef m)
----------------
mstorsjo wrote:
I don't really have a strong opinion on it; moving the constructor to the .cpp file here adds a bit more churn if it can be moved back to the header later, so it's probably fine to keep it like this for now - I mostly wanted to raise the issue and hear the reasoning around it.
https://github.com/llvm/llvm-project/pull/119296
More information about the llvm-commits
mailing list