[lld] [LLD][COFF] Store reference to SymbolTable instead of COFFLinkerContext in InputFile (NFC) (PR #119296)

Jacek Caban via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 10:17:51 PST 2024


================
@@ -403,8 +404,8 @@ class BitcodeFile : public InputFile {
 // .dll file. MinGW only.
 class DLLFile : public InputFile {
 public:
-  explicit DLLFile(COFFLinkerContext &ctx, MemoryBufferRef m)
-      : InputFile(ctx, DLLKind, m) {}
+  explicit DLLFile(SymbolTable &symtab, MemoryBufferRef m)
----------------
cjacek wrote:

Ah, I remember now why I didn't change it: the constructor would need to be moved out of the header because `COFFLinkerContext` is an incomplete type in `InputFiles.h`. Since it will ultimately use the `symtab` argument (as mentioned above), I updated the type in this commit already. Should I change it?

https://github.com/llvm/llvm-project/pull/119296


More information about the llvm-commits mailing list