[llvm] [GlobalISel][AArch64] Legalize G_FABS and G_FNEG for SVE (PR #114784)

[Craig Topper via llvm-commits]

Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/114784 at github.com>


topperc wrote:

> You don't have to tell us that you have other things to do. We all know that you never contribute. Putting unlimited burden on contributors is a very special kind of review style.

This comment is inappropriate.

You have been asked to consider the big picture of how SVE will work in GISel. SelectionDAG supports both fixed and scalable vectors using SVE registers with the same isel patterns. This is done by converting them to a common interface in C++ code. Do you think that GISel should do something different to support fixed vectors? If you want to do something different, I think it is your responsibility to make a proposal. We shouldn't just ignore fixed vectors for expediency.

https://github.com/llvm/llvm-project/pull/114784