[llvm] [AArch64] Combine and and lsl into ubfiz (PR #118974)

David Sherwood via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 08:16:22 PST 2024


https://github.com/david-arm commented:

The codegen changes seem like an overall win to me. Nice! I had a few comments.

Just a general question - did you try seeing if the SHL combine could be done in the general DAGCombiner to get the same effect? It seems like a sensible canonicalisation to do, mirroring what InstCombine does at the IR level. I just wondered if you saw regressions in other targets when doing that, or if something else got in the way? Thanks!

https://github.com/llvm/llvm-project/pull/118974


More information about the llvm-commits mailing list