[llvm] [BOLT][AArch64] Fix strict usage during ADR Relax (PR #71377)

Vladislav Khmelevsky via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 11 22:49:06 PST 2024


================
@@ -72,14 +72,17 @@ void ADRRelaxationPass::runOnFunction(BinaryFunction &BF) {
 
       if (It != BB.begin() && BC.MIB->isNoop(*std::prev(It))) {
         It = BB.eraseInstruction(std::prev(It));
-      } else if (opts::StrictMode && !BF.isSimple()) {
+      } else if (std::next(It) != BB.end() && BC.MIB->isNoop(*std::next(It))) {
+        BB.eraseInstruction(std::next(It));
+      } else if (!opts::StrictMode && !BF.isSimple()) {
----------------
yota9 wrote:

I don't really mind. Ideally here should be option with a list of functions that are allowed to be skipped with this error. But I think someone who'll need this can implement this :)

https://github.com/llvm/llvm-project/pull/71377


More information about the llvm-commits mailing list