[llvm] [memprof] Use addCallStack in a unit test (NFC) (PR #119651)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 11 19:11:21 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-pgo
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
Here IndexedMemProfRecord just needs to reference a CallStackID, so we
can use addCallStack for a real hash-based CallStackId instead of a
fake value like 0x222.
---
Full diff: https://github.com/llvm/llvm-project/pull/119651.diff
1 Files Affected:
- (modified) llvm/unittests/ProfileData/MemProfTest.cpp (+4-6)
``````````diff
diff --git a/llvm/unittests/ProfileData/MemProfTest.cpp b/llvm/unittests/ProfileData/MemProfTest.cpp
index 8b700673814c3d..5602b8a1ec9b42 100644
--- a/llvm/unittests/ProfileData/MemProfTest.cpp
+++ b/llvm/unittests/ProfileData/MemProfTest.cpp
@@ -556,14 +556,12 @@ TEST(MemProf, MissingCallStackId) {
}
TEST(MemProf, MissingFrameId) {
- IndexedAllocationInfo AI(0x222, makePartialMIB(), getHotColdSchema());
-
- IndexedMemProfRecord IndexedMR;
- IndexedMR.AllocSites.push_back(AI);
-
// An empty Frame map to trigger a mapping error.
IndexedMemProfData MemProfData;
- MemProfData.CallStacks.insert({0x222, {2, 3}});
+ auto CSId = MemProfData.addCallStack(SmallVector<FrameId>{2, 3});
+
+ IndexedMemProfRecord IndexedMR;
+ IndexedMR.AllocSites.emplace_back(CSId, makePartialMIB(), getHotColdSchema());
FrameIdConverter<decltype(MemProfData.Frames)> FrameIdConv(
MemProfData.Frames);
``````````
</details>
https://github.com/llvm/llvm-project/pull/119651
More information about the llvm-commits
mailing list