[llvm] [memprof] Use addCallStack in a unit test (NFC) (PR #119651)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 11 19:10:40 PST 2024
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/119651
Here IndexedMemProfRecord just needs to reference a CallStackID, so we
can use addCallStack for a real hash-based CallStackId instead of a
fake value like 0x222.
>From 4ce1d58e116deec6170243a1c46499ce8baed5bf Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Wed, 11 Dec 2024 18:26:05 -0800
Subject: [PATCH] [memprof] Use addCallStack in a unit test (NFC)
Here IndexedMemProfRecord just needs to reference a CallStackID, so we
can use addCallStack for a real hash-based CallStackId instead of a
fake value like 0x222.
---
llvm/unittests/ProfileData/MemProfTest.cpp | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/llvm/unittests/ProfileData/MemProfTest.cpp b/llvm/unittests/ProfileData/MemProfTest.cpp
index 8b700673814c3d..5602b8a1ec9b42 100644
--- a/llvm/unittests/ProfileData/MemProfTest.cpp
+++ b/llvm/unittests/ProfileData/MemProfTest.cpp
@@ -556,14 +556,12 @@ TEST(MemProf, MissingCallStackId) {
}
TEST(MemProf, MissingFrameId) {
- IndexedAllocationInfo AI(0x222, makePartialMIB(), getHotColdSchema());
-
- IndexedMemProfRecord IndexedMR;
- IndexedMR.AllocSites.push_back(AI);
-
// An empty Frame map to trigger a mapping error.
IndexedMemProfData MemProfData;
- MemProfData.CallStacks.insert({0x222, {2, 3}});
+ auto CSId = MemProfData.addCallStack(SmallVector<FrameId>{2, 3});
+
+ IndexedMemProfRecord IndexedMR;
+ IndexedMR.AllocSites.emplace_back(CSId, makePartialMIB(), getHotColdSchema());
FrameIdConverter<decltype(MemProfData.Frames)> FrameIdConv(
MemProfData.Frames);
More information about the llvm-commits
mailing list