[llvm] IR: Allow vector type in atomic load and store (PR #117625)
James Y Knight via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 4 14:24:09 PST 2024
jyknight wrote:
> Yes, the codegen patch should implement the generic path for all targets. But in terms of patch splitting, that shouldn't be in this PR
I somewhat disagree -- I do think it makes more sense to do this in one commit -- especially since the necessary codegen changes are small. However, that's only a weak preference; if the author wishes to do this in a series of PRs, that's also OK as long they'll all land together.
> We really should get rid of these hooks. There's no reason this can't just be handled by ordinary type legalization
Sounds great, but _that_ certainly seems like a separable change. Since these hooks are how it's done today for floats, I don't see a reason to (initially) do something different for vectors.
https://github.com/llvm/llvm-project/pull/117625
More information about the llvm-commits
mailing list